Paths

Table of Contentst

Differential D14406

Fix CSS Remarkup rule bleed
ClosedPublic
Actions

Authored by chad on Nov 4 2015, 9:35 PM.

Details

Reviewers

epriestley

Commits

Restricted Diffusion Commit
rP3651202ac65d: Fix CSS Remarkup rule bleed

Summary

This margin rule is bleeding in some cases where we wrap phabricator-remarkup around a large amount of other content (like Dialogs). This restricts the rule to the first direct child.

Test Plan

Go to a workboard, edit a task, see proper alignment of icons.

Diff Detail

Repository

rP Phabricator

Branch

remarkup-derp

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 8617
Build 9967: Run Core Tests
Build 9966: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 34807.Nov 4 2015, 9:35 PM

chad retitled this revision from to Fix CSS Remarkup rule bleed.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

Herald added a subscriber: Korvin. · View Herald TranscriptNov 4 2015, 9:35 PM

epriestley accepted this revision.Nov 4 2015, 9:35 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Nov 4 2015, 9:35 PM

Closed by commit rP3651202ac65d: Fix CSS Remarkup rule bleed (authored by chad, committed by chad). · Explain WhyNov 4 2015, 9:36 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

6 lines

webroot/

rsrc/

css/

core/

remarkup.css

2 lines

Diff 34807

View Options

resources/celerity/map.php