Page MenuHomePhabricator
Differential D14404

Provide formal Users/Projects/Mailable fields for EditEngine
ClosedPublic
Actions

Authored by epriestley on Nov 4 2015, 6:37 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jan 30, 7:38 AM
Unknown Object (File)
Tue, Jan 28, 2:54 AM
Unknown Object (File)
Fri, Jan 24, 9:42 AM
Unknown Object (File)
Thu, Jan 23, 2:46 PM
Unknown Object (File)
Tue, Jan 21, 11:18 AM
Unknown Object (File)
Fri, Jan 17, 6:15 PM
Unknown Object (File)
Thu, Jan 16, 4:28 AM
Unknown Object (File)
Sun, Jan 12, 5:18 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T9132: Build an ApplicationEditor abstraction
Commits
Restricted Diffusion Commit
rP621f806e3b54: Provide formal Users/Projects/Mailable fields for EditEngine
Summary

Ref T9132. This allows you to prefill EditEngine forms with stuff like ?subscribers=epriestley, and we'll figure out what you mean.

Test Plan
  • Did /?subscribers=... with various values (good, bad, mis-capitalized).
  • Did /?projects=... with various values (good, bad, mis-capitalized).
  • Reviewed documentation.
  • Reviewed Config → HTTP Parameter Types.

Diff Detail

Repository
rP Phabricator
Branch
eengine10
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/transactions/editfield/PhabricatorSubscribersEditField.php:11XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 8612
Build 9960: Run Core Tests
Build 9959: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 34802.Nov 4 2015, 6:37 PM
epriestley retitled this revision from to Provide formal Users/Projects/Mailable fields for EditEngine.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T9132: Build an ApplicationEditor abstraction.
epriestley added a comment.Nov 4 2015, 6:38 PM

Screen Shot 2015-11-04 at 10.34.37 AM.png (516×857 px, 113 KB)

chad accepted this revision.Nov 4 2015, 7:07 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 4 2015, 7:07 PM
Closed by commit rP621f806e3b54: Provide formal Users/Projects/Mailable fields for EditEngine (authored by epriestley, committed by epriestley). · Explain WhyNov 4 2015, 8:05 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 34802

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/aphront/httpparametertype/AphrontProjectListHTTPParameterType.php

Loading...
View Options

src/aphront/httpparametertype/AphrontUserListHTTPParameterType.php

Loading...
View Options

src/applications/phid/resolver/PhabricatorPHIDResolver.php

Loading...
View Options

src/applications/phid/resolver/PhabricatorProjectPHIDResolver.php

Loading...
View Options

src/applications/phid/resolver/PhabricatorUserPHIDResolver.php

Loading...
View Options

src/applications/transactions/editengine/PhabricatorApplicationEditEngine.php

Loading...
View Options

src/applications/transactions/editfield/PhabricatorProjectsEditField.php

Loading...
View Options

src/applications/transactions/editfield/PhabricatorSubscribersEditField.php

Loading...
View Options

src/applications/transactions/editfield/PhabricatorUsersEditField.php

Loading...
Phabricator · Built by Phacility