Moves Phriction to use PHUIDocumentViewPro
Details
- Reviewers
epriestley - Maniphest Tasks
- T9826: Phriction saved page is not same as previewing one
- Commits
- Restricted Diffusion Commit
rPbf227f77a5dc: Update Phriction for PHUIDocumentViewPro
Read lots of documents, tablet, mobile, and desktop. Check ToC, non ToC, Edit a Maniphest Task, New Phriction Document, edit Phriction Document.
Diff Detail
- Repository
- rP Phabricator
- Branch
- phriction-pro
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 8595 Build 9935: Run Core Tests Build 9934: arc lint + arc unit
Event Timeline
src/applications/phriction/controller/PhrictionDocumentController.php | ||
---|---|---|
462 | Having issues getting this to kick back the Table of Contents... but I pulled it from PhrictionContent. What's the best place to get the ToC as a separate entity? |
src/applications/phriction/controller/PhrictionDocumentController.php | ||
---|---|---|
463 | The $engine you're using here is empty, while the $engine in the original is one that has been used to process the text. If you do a purely standalone generation of the TOC, you'll have to do the work for generating it twice -- once to generate the body, then once to regenerate it to get the TOC. Easiest fix for now at least is probably making didMarkupText() just have a side effect like: $this->renderedTableOfContents = ... ...then add a method like: public function getRenderedTableOfContents() { if ($this->renderedTableOfContents === null) { throw new PhutiIInalidStateException('didMarkupText'); } return $this-> renderedTableOfContents; } ...to fetch it. I think that will work until I can clean up Remarkup more generally. |