Adds highlight commands to Remarkup book. Fixes T5560
Details
Details
- Reviewers
epriestley - Maniphest Tasks
- T5560: Add some sort of highlighting syntax to Remarkup
- Commits
- Restricted Diffusion Commit
rP0476140f3c1b: Add highlight rules to diviner
build books
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- highlight-div
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 8564 Build 9889: Run Core Tests Build 9888: arc lint + arc unit
Event Timeline
Comment Actions
Actually getting an Exception when generating:
[2015-11-02 13:27:12] EXCEPTION: (Exception) No such atom with node hash '8ae0e56e68c9919ffe35720e3eac36feN'! at [<phabricator>/src/applications/diviner/workflow/DivinerGenerateWorkflow.php:528] arcanist(head=master, ref.master=2db40f995337), corgi(head=master, ref.master=ad26f63a398b), phabricator(head=highlight-div, ref.master=8bbcd896b806, ref.highlight-div=8b32c2a17f23), phutil(head=master, ref.master=ceca9d1122ea) #0 DivinerGenerateWorkflow::computeSymbolHash(string) called at [<phabricator>/src/applications/diviner/workflow/DivinerGenerateWorkflow.php:497] #1 DivinerGenerateWorkflow::buildGraphCache() called at [<phabricator>/src/applications/diviner/workflow/DivinerGenerateWorkflow.php:177] #2 DivinerGenerateWorkflow::generateBook(string, PhutilArgumentParser) called at [<phabricator>/src/applications/diviner/workflow/DivinerGenerateWorkflow.php:80] #3 DivinerGenerateWorkflow::execute(PhutilArgumentParser) called at [<phutil>/src/parser/argument/PhutilArgumentParser.php:406] #4 PhutilArgumentParser::parseWorkflowsFull(array) called at [<phutil>/src/parser/argument/PhutilArgumentParser.php:301] #5 PhutilArgumentParser::parseWorkflows(array) called at [<phabricator>/scripts/diviner/diviner.php:21] family:phabricator familyroom$
Comment Actions
I think we have a couple of cache issues with Diviner that I haven't hunted down, usually doing bin/diviner generate --clean will fix it.