Page MenuHomePhabricator
Differential D14386

Phurl URL object should show a banner if the URL is invalid
ClosedPublic
Actions

Authored by lpriestley on Nov 2 2015, 9:06 PM.
Tags
None
Referenced Files
F14053875: D14386.diff
Fri, Nov 15, 8:08 PM
F14051124: D14386.diff
Thu, Nov 14, 10:24 PM
F14043028: D14386.diff
Tue, Nov 12, 7:21 AM
F14039705: D14386.id.diff
Mon, Nov 11, 6:13 AM
F14031445: D14386.id34750.diff
Sat, Nov 9, 10:31 AM
F14031444: D14386.id34749.diff
Sat, Nov 9, 10:31 AM
F14031443: D14386.id.diff
Sat, Nov 9, 10:31 AM
F14026511: D14386.id34750.diff
Fri, Nov 8, 1:23 AM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T8989: Phurl objects should have a link like "Visit URL".
Commits
Restricted Diffusion Commit
rP99daadb251ca: Phurl URL object should show a banner if the URL is invalid
Summary

Ref T8989, Phurl URL should always show an info banner if the URL isn't valid

Test Plan

Phurl objects with URL "google.com" should show an error banner, but objects with URL "http://google.com" should not show banner.

Diff Detail

Repository
rP Phabricator
Branch
phurlurlinfobanner
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 8559
Build 9882: arc lint + arc unit

Event Timeline

lpriestley updated this revision to Diff 34749.Nov 2 2015, 9:06 PM
lpriestley retitled this revision from to Phurl URL object should show a banner if the URL is invalid.
lpriestley updated this object.
lpriestley edited the test plan for this revision. (Show Details)
lpriestley added a reviewer: epriestley.
lpriestley added a task: T8989: Phurl objects should have a link like "Visit URL"..
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptNov 2 2015, 9:06 PM
Herald added a subscriber: Korvin. · View Herald Transcript
epriestley accepted this revision.Nov 2 2015, 9:07 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Nov 2 2015, 9:07 PM
Closed by commit rP99daadb251ca: Phurl URL object should show a banner if the URL is invalid (authored by lpriestley, committed by lpriestley). · Explain WhyNov 2 2015, 9:09 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
phurl/
controller/
6 lines

Diff 34749

View Options

src/applications/phurl/controller/PhabricatorPhurlURLViewController.php

Loading...
Phabricator · Built by Phacility