Differential D14386

Phurl URL object should show a banner if the URL is invalid
ClosedPublic
Actions

Authored by lpriestley on Nov 2 2015, 9:06 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T8989: Phurl objects should have a link like "Visit URL".

Commits

Restricted Diffusion Commit
rP99daadb251ca: Phurl URL object should show a banner if the URL is invalid

Summary

Ref T8989, Phurl URL should always show an info banner if the URL isn't valid

Test Plan

Phurl objects with URL "google.com" should show an error banner, but objects with URL "http://google.com" should not show banner.

Diff Detail

Repository

rP Phabricator

Branch

phurlurlinfobanner

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 8559
Build 9882: arc lint + arc unit

Event Timeline

lpriestley updated this revision to Diff 34749.Nov 2 2015, 9:06 PM

lpriestley retitled this revision from to Phurl URL object should show a banner if the URL is invalid.

lpriestley updated this object.

lpriestley edited the test plan for this revision. (Show Details)

lpriestley added a reviewer: epriestley.

lpriestley added a task: T8989: Phurl objects should have a link like "Visit URL"..

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptNov 2 2015, 9:06 PM

Herald added a subscriber: Korvin. · View Herald Transcript

epriestley accepted this revision.Nov 2 2015, 9:07 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Nov 2 2015, 9:07 PM

Closed by commit rP99daadb251ca: Phurl URL object should show a banner if the URL is invalid (authored by lpriestley, committed by lpriestley). · Explain WhyNov 2 2015, 9:09 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

phurl/

controller/

PhabricatorPhurlURLViewController.php

6 lines

Diff 34749

View Options

src/applications/phurl/controller/PhabricatorPhurlURLViewController.php

Phurl URL object should show a banner if the URL is invalidClosedPublicActions