Write more detailed documentation about Differential inlines
ClosedPublic
Actions

Authored by epriestley on Oct 25 2015, 7:27 PM.

Details

Reviewers

Maniphest Tasks

T9628: When viewing a diff in differential, and making comments against specific lines, the comment submitted should be against what was seen

Commits

Restricted Diffusion Commit
rP2beeb2fab0e2: Write more detailed documentation about Differential inlines

Summary

Ref T9628. The porting feature has been fairly stable for a while, so make some reasonable effort to document how it works and some of the tradeoffs it involves.

Test Plan

Generated and read documentation.

Diff Detail

Repository

rP Phabricator

Branch

idoc

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 8408
Build 9661: Run Core Tests
Build 9660: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 34599.Oct 25 2015, 7:27 PM

epriestley retitled this revision from to Write more detailed documentation about Differential inlines.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T9628: When viewing a diff in differential, and making comments against specific lines, the comment submitted should be against what was seen.

chad accepted this revision.Oct 25 2015, 8:55 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Oct 25 2015, 8:55 PM

chad added inline comments.Oct 25 2015, 8:56 PM

src/docs/user/userguide/differential_inlines.diviner
163	You seem to usually write this differently
163	Formatting I mean

epriestley added inline comments.Oct 25 2015, 8:59 PM

src/docs/user/userguide/differential_inlines.diviner
163	Oh yeah, I copy/pasted an older-style version of this, I'll make it consistent.

Closed by commit rP2beeb2fab0e2: Write more detailed documentation about Differential inlines (authored by epriestley, committed by epriestley). · Explain WhyOct 25 2015, 9:51 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

docs/

user/

userguide/

differential.diviner

29 lines

differential_inlines.diviner

167 lines

Diff 34599

View Options

src/docs/user/userguide/differential.diviner