Page MenuHomePhabricator
Differential D14314

Show a more reasonable status element for pull requests
ClosedPublic
Actions

Authored by epriestley on Oct 20 2015, 11:31 PM.
Tags
None
Referenced Files
F15508242: D14314.diff
Wed, Apr 16, 3:42 AM
F15431401: D14314.id.diff
Mon, Mar 24, 12:09 PM
F15403480: D14314.diff
Tue, Mar 18, 3:33 AM
F15396565: D14314.diff
Mar 16 2025, 3:08 PM
F15389285: D14314.id.diff
Mar 15 2025, 5:05 AM
F15378596: D14314.id34556.diff
Mar 13 2025, 3:38 PM
F15290795: D14314.id34552.diff
Mar 4 2025, 11:47 PM
Unknown Object (File)
Feb 18 2025, 2:58 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T182: Commit into repository directly from differential
Commits
Restricted Diffusion Commit
rP5b619862cb06: Show a more reasonable status element for pull requests
Summary

Ref T182. Replace the total mess we had before with a sort-of-reasonable element.

This automatically updates using "javascript".

Test Plan

Screen Shot 2015-10-20 at 4.05.54 PM.png (725×1 px, 132 KB)

Screen Shot 2015-10-20 at 4.28.50 PM.png (871×1 px, 141 KB)

Used "Land Revision", saw the land status go from "Waiting" -> "Working" -> "Landed" without having to mash reload over and over again.

Diff Detail

Repository
rP Phabricator
Branch
pull1
Lint
Lint Warnings
SeverityLocationCodeMessage
Warningwebroot/rsrc/js/application/drydock/drydock-live-operation-status.js:1JAVELIN5`javelinsymbols` Not In Path
Advicesrc/applications/drydock/view/DrydockRepositoryOperationStatusView.php:76XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 8363
Build 9598: Run Core Tests
Build 9597: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 34552.Oct 20 2015, 11:31 PM
epriestley retitled this revision from to Show a more reasonable status element for pull requests.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T182: Commit into repository directly from differential.
chad accepted this revision.Oct 21 2015, 12:47 AM
chad edited edge metadata.
This revision is now accepted and ready to land.Oct 21 2015, 12:47 AM
Closed by commit rP5b619862cb06: Show a more reasonable status element for pull requests (authored by epriestley, committed by epriestley). · Explain WhyOct 21 2015, 6:28 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
7 lines
src/
4 lines
applications/
differential/
controller/
29 lines
drydock/
application/
1 line
controller/
59 lines
operation/
24 lines
4 lines
storage/
16 lines
view/
84 lines
webroot/
rsrc/
js/
application/
drydock/
32 lines

Diff 34552

View Options

resources/celerity/map.php

Loading...
View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/differential/controller/DifferentialRevisionViewController.php

Loading...
View Options

src/applications/drydock/application/PhabricatorDrydockApplication.php

Loading...
View Options

src/applications/drydock/controller/DrydockRepositoryOperationStatusController.php

Loading...
View Options

src/applications/drydock/operation/DrydockLandRepositoryOperation.php

Loading...
View Options

src/applications/drydock/operation/DrydockRepositoryOperationType.php

Loading...
View Options

src/applications/drydock/storage/DrydockRepositoryOperation.php

Loading...
View Options

src/applications/drydock/view/DrydockRepositoryOperationStatusView.php

Loading...
View Options

webroot/rsrc/js/application/drydock/drydock-live-operation-status.js

Loading...
Phabricator · Built by Phacility