Differential D14306

Restrict Workboard initialization to CAN_EDIT
ClosedPublic
Actions

Authored by chad on Oct 19 2015, 8:19 PM.

Details

Reviewers

epriestley

Maniphest Tasks

T7410: Allow a project's workboard to be disabled so that tagged tasks no longer show meaningless "(Backlog)"

Commits

Restricted Diffusion Commit
rPec485de8f977: Restrict Workboard initialization to CAN_EDIT

Summary

Make Workboard initialization more restrictive.

Test Plan

Log out, see "No Workboard", Log in with permissions, see "New Workboard", Log in with notchad, see "No Workboard".

Diff Detail

Repository

rP Phabricator

Branch

workboard-edit-2

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 8343
Build 9571: Run Core Tests
Build 9570: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 34530.Oct 19 2015, 8:19 PM

chad retitled this revision from to Restrict Workboard initialization to CAN_EDIT.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

Herald added a subscriber: Korvin. · View Herald TranscriptOct 19 2015, 8:19 PM

epriestley accepted this revision.Oct 19 2015, 8:19 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Oct 19 2015, 8:19 PM

chad added a task: T7410: Allow a project's workboard to be disabled so that tagged tasks no longer show meaningless "(Backlog)".Oct 19 2015, 8:22 PM

Closed by commit rPec485de8f977: Restrict Workboard initialization to CAN_EDIT (authored by chad, committed by chad). · Explain WhyOct 19 2015, 8:22 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

project/

controller/

PhabricatorProjectBoardViewController.php

6 lines

Diff 34530

View Options

src/applications/project/controller/PhabricatorProjectBoardViewController.php

Restrict Workboard initialization to CAN_EDITClosedPublicActions