Differential D14280

When landing revisions via repository automation, use better metadata
ClosedPublic
Actions

Authored by epriestley on Oct 14 2015, 5:39 PM.

Details

Reviewers

chad

Maniphest Tasks

T182: Commit into repository directly from differential

Commits

Restricted Diffusion Commit
rPf3f3d957021b: When landing revisions via repository automation, use better metadata

Summary

Ref T182. Make a reasonable attempt to get the commit message, author, and committer data correct.

Test Plan

BEHOLD: rGITTEST810b7f17cd0c909256a45d29a5062fcf417d0489

Diff Detail

Repository

rP Phabricator

Branch

dock3

Lint

Lint Passed

Severity	Location	Code	Message
Advice	src/applications/drydock/operation/DrydockLandRepositoryOperation.php:136	XHP16	TODO Comment

Unit

Tests Passed

Build Status

Buildable 8284
Build 9489: Run Core Tests
Build 9488: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 34470.Oct 14 2015, 5:39 PM

epriestley retitled this revision from to When landing revisions via repository automation, use better metadata.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T182: Commit into repository directly from differential.

chad accepted this revision.Oct 14 2015, 5:39 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Oct 14 2015, 5:39 PM

Closed by commit rPf3f3d957021b: When landing revisions via repository automation, use better metadata (authored by epriestley, committed by epriestley). · Explain WhyOct 14 2015, 5:50 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

storage/

DifferentialDiff.php

6 lines

drydock/

operation/

DrydockLandRepositoryOperation.php

55 lines

Diff 34470

View Options

src/applications/differential/storage/DifferentialDiff.php