Page MenuHomePhabricator
Differential D14264

Work around an issue with custom "users" fields in Maniphest
ClosedPublic
Actions

Authored by epriestley on Oct 13 2015, 2:51 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jan 27, 9:01 PM
Unknown Object (File)
Mon, Jan 27, 9:01 PM
Unknown Object (File)
Mon, Jan 27, 9:01 PM
Unknown Object (File)
Sat, Jan 25, 7:23 AM
Unknown Object (File)
Sat, Jan 25, 6:09 AM
Unknown Object (File)
Fri, Jan 24, 9:21 AM
Unknown Object (File)
Wed, Jan 22, 9:26 PM
Unknown Object (File)
Wed, Jan 22, 2:58 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T9558: Unhandled Exception on adding a Phabricator user to a Maniphest custom field
Commits
Restricted Diffusion Commit
rPc0a52201a899: (stable) Work around an issue with custom "users" fields in Maniphest
rP0b6c0310424b: Work around an issue with custom "users" fields in Maniphest
Summary

Fixes T9558. The recent changes to validate PHID fields don't work cleanly with this gross hack.

This can probably be unwound now but it will definitely get fixed in T9132 so I may just wait for that.

Test Plan

Edited a custom "users" field in Maniphest. This should only affect Maniphest because it has a weird hack.

Diff Detail

Repository
rP Phabricator
Branch
edithack1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 8253
Build 9446: Run Core Tests
Build 9445: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 34438.Oct 13 2015, 2:51 PM
epriestley retitled this revision from to Work around an issue with custom "users" fields in Maniphest.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T9558: Unhandled Exception on adding a Phabricator user to a Maniphest custom field.
chad accepted this revision.Oct 13 2015, 3:08 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Oct 13 2015, 3:08 PM
Closed by commit rP0b6c0310424b: Work around an issue with custom "users" fields in Maniphest (authored by epriestley, committed by epriestley). · Explain WhyOct 13 2015, 3:41 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
maniphest/
controller/
3 lines

Diff 34438

View Options

src/applications/maniphest/controller/ManiphestTaskEditController.php

Loading...
Phabricator · Built by Phacility