Page MenuHomePhabricator

Improve ruleset for generating project hashtags
ClosedPublic

Authored by epriestley on Oct 12 2015, 11:55 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 13, 5:49 PM
Unknown Object (File)
Sun, Dec 8, 4:59 PM
Unknown Object (File)
Sun, Dec 8, 4:24 PM
Unknown Object (File)
Thu, Dec 5, 1:01 AM
Unknown Object (File)
Sun, Dec 1, 1:57 PM
Unknown Object (File)
Nov 10 2024, 9:26 PM
Unknown Object (File)
Nov 8 2024, 12:38 PM
Unknown Object (File)
Nov 8 2024, 12:38 PM
Subscribers
None

Details

Summary

Ref T9551. We currently use the same logic for generating project hashtags and Phriction slugs, but should be a little more conservative with project hashtags.

Stop them from generating with stuff that won't parse in a "Reviewers:" field or generally in commments (commas, colons, etc).

Test Plan

Created a bunch of projects with nonsense in them and saw them generate pretty reasonable hashtags.

Screen Shot 2015-10-12 at 4.54.40 PM.png (322×706 px, 35 KB)

Diff Detail

Repository
rP Phabricator
Branch
projslug2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 8241
Build 9432: Run Core Tests
Build 9431: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Improve ruleset for generating project hashtags.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.

FWIW, I sort of preferred _-_, but whatevs.

chad edited edge metadata.
This revision is now accepted and ready to land.Oct 12 2015, 11:58 PM

The _-_ thing mostly feels kinda buggy/janky to me in URIs. Like /w/engineering-onboarding/ is way better than /w/engineering_-_onboarding/ I think?

I think it's sort of moot since these inter-word hyphens should probably always be subpages (for Phriction) or subprojects (when those get built) but it was ~free to change/test while I was in here anyway.

resources/sql/patches/090.forceuniqueprojectnames.php
2

We could probably just remove this migration since it is approximately 35 years old, but I think this upgrade preserves it faithfully.

This also very nearly gets rid of all the "phriction slug" junk, but not quite. I'm not sure if I'm feeling ambitious enough to try migrating it on top of this. Maybe I'll give this a week to settle and then try it.

I shoved it into a tiny corner at least so we can almost forget that it exists even if I don't do the migration for a bit.

This revision was automatically updated to reflect the committed changes.

I just felt it more accurately represented the Project. Like a hyphenated word is different than two words with spaces between the hyphens.