Page MenuHomePhabricator

Fix several error handling issues with Subversion commits in Diffusion
ClosedPublic

Authored by epriestley on Oct 5 2015, 10:50 PM.
Tags
None
Referenced Files
F14873304: D14239.diff
Sat, Feb 8, 5:04 AM
Unknown Object (File)
Sun, Feb 2, 5:00 AM
Unknown Object (File)
Sat, Feb 1, 8:35 PM
Unknown Object (File)
Tue, Jan 28, 6:53 PM
Unknown Object (File)
Sat, Jan 25, 1:22 AM
Unknown Object (File)
Fri, Jan 24, 9:18 AM
Unknown Object (File)
Fri, Jan 24, 9:18 AM
Unknown Object (File)
Fri, Jan 24, 9:18 AM
Subscribers
None

Details

Summary

Ref T9513. I checked this briefly but didn't do a very thorough job of it.

  • Don't try to query merges for Subversion, since it doesn't support them.
  • Fix up "existsquery" to work properly (and efficiently) for both hosted and imported repositories.
  • Fix up "parentsquery" to have similar behavior on invalid commits to other VCSes (throw an exception).
Test Plan
  • No more merges warning on SVN.
  • Hosted SVN gets the right exists result now.
  • Visiting "r23980283789287" now 404's instead of "not parsed yet".

Diff Detail

Repository
rP Phabricator
Branch
svnx1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 8189
Build 9363: Run Core Tests
Build 9362: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Fix several error handling issues with Subversion commits in Diffusion.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Oct 5 2015, 10:52 PM
This revision was automatically updated to reflect the committed changes.