Page MenuHomePhabricator
Differential D14217

Use getPhobjectClassConstant() to access class constants
ClosedPublic
Actions

Authored by epriestley on Oct 1 2015, 8:27 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 19, 11:01 PM
Unknown Object (File)
Thu, Dec 12, 5:07 AM
Unknown Object (File)
Tue, Dec 3, 7:41 PM
Unknown Object (File)
Fri, Nov 29, 11:47 PM
Unknown Object (File)
Wed, Nov 27, 3:57 PM
Unknown Object (File)
Nov 22 2024, 10:29 PM
Unknown Object (File)
Nov 20 2024, 12:32 PM
Unknown Object (File)
Nov 20 2024, 12:32 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T9494: Standardize GarbageCollector TTLs
Commits
Restricted Diffusion Commit
rPe431ab218923: Use getPhobjectClassConstant() to access class constants
Summary

Ref T9494. Depends on D14216. Remove 10 copies of this code.

Test Plan

Ran arc unit --everything, browsed Config > Modules, clicked around Herald / etc.

Diff Detail

Repository
rP Phabricator
Branch
dx3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 8138
Build 9292: Run Core Tests
Build 9291: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 34330.Oct 1 2015, 8:27 PM
epriestley retitled this revision from to Use getPhobjectClassConstant() to access class constants.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T9494: Standardize GarbageCollector TTLs.
epriestley added a parent revision: D14216: Add getPhobjectClassConstant() to Phobject.
chad accepted this revision.Oct 1 2015, 8:32 PM
chad updated this object.
chad edited edge metadata.
This revision is now accepted and ready to land.Oct 1 2015, 8:33 PM
Closed by commit rPe431ab218923: Use getPhobjectClassConstant() to access class constants (authored by epriestley, committed by epriestley). · Explain WhyOct 1 2015, 11:56 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
drydock/
logtype/
30 lines
harbormaster/
artifact/
30 lines
stepgroup/
14 lines
herald/
action/
30 lines
14 lines
field/
28 lines
14 lines
phid/
type/
12 lines
policy/
capability/
24 lines
infrastructure/
edges/
type/
12 lines

Diff 34330

View Options

src/applications/drydock/logtype/DrydockLogType.php

Loading...
View Options

src/applications/harbormaster/artifact/HarbormasterArtifact.php

Loading...
View Options

src/applications/harbormaster/stepgroup/HarbormasterBuildStepGroup.php

Loading...
View Options

src/applications/herald/action/HeraldAction.php

Loading...
View Options

src/applications/herald/action/HeraldActionGroup.php

Loading...
View Options

src/applications/herald/field/HeraldField.php

Loading...
View Options

src/applications/herald/field/HeraldFieldGroup.php

Loading...
View Options

src/applications/phid/type/PhabricatorPHIDType.php

Loading...
View Options

src/applications/policy/capability/PhabricatorPolicyCapability.php

Loading...
View Options

src/infrastructure/edges/type/PhabricatorEdgeType.php

Loading...
Phabricator · Built by Phacility