Differential D14216

Add getPhobjectClassConstant() to Phobject
ClosedPublic
Actions

Authored by epriestley on Oct 1 2015, 8:26 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Feb 14, 3:44 AM

	Unknown Object (File)
	Wed, Feb 12, 12:04 AM

	Unknown Object (File)
	Wed, Feb 12, 12:04 AM

	Unknown Object (File)
	Wed, Feb 12, 12:04 AM

	Unknown Object (File)
	Sat, Feb 8, 11:27 PM

	Unknown Object (File)
	Sat, Feb 8, 5:45 AM

	Unknown Object (File)
	Sat, Feb 8, 4:59 AM

	Unknown Object (File)
	Sat, Feb 8, 4:59 AM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T9494: Standardize GarbageCollector TTLs

Commits

rPHU367fadac24f2: (stable) Promote 2015 Week 40
rPHUd0105f145688: Add getPhobjectClassConstant() to Phobject

Summary

Ref T9494. We have like 20 copies of this code, just add a helper method to the base class.

Test Plan

See next change.

Diff Detail

Repository

Branch

phobject1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 8137
Build 9290: Run Core Tests
Build 9289: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	96 ms	PhutilRemarkupEngineTestCase::Unknown Unit Message ("")
	8 ms	PhutilXHPASTSyntaxHighlighterTestCase::Unknown Unit Message ("")
	0 ms	AbstractDirectedGraphTestCase::Unknown Unit Message ("")
	0 ms	AbstractDirectedGraphTestCase::Unknown Unit Message ("")
	0 ms	AbstractDirectedGraphTestCase::Unknown Unit Message ("")
		View Full Test Results (2 Failed · 273 Passed · 2 Skipped)

Event Timeline

epriestley updated this revision to Diff 34329.Oct 1 2015, 8:26 PM

epriestley retitled this revision from to Add getPhobjectClassConstant() to Phobject.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T9494: Standardize GarbageCollector TTLs.

epriestley added a child revision: D14217: Use getPhobjectClassConstant() to access class constants.

chad accepted this revision.Oct 1 2015, 8:32 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Oct 1 2015, 8:32 PM

Closed by commit rPHUd0105f145688: Add getPhobjectClassConstant() to Phobject (authored by epriestley, committed by epriestley). · Explain WhyOct 1 2015, 11:56 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

object/

41 lines

Diff 34329

src/object/Phobject.php

Loading...