Page MenuHomePhabricator
Differential D14202

Merge the DrydockLease workers into a single worker
ClosedPublic
Actions

Authored by epriestley on Sep 30 2015, 9:42 PM.
Tags
None
Referenced Files
F14762009: D14202.diff
Thu, Jan 23, 4:14 AM
Unknown Object (File)
Tue, Jan 21, 8:40 PM
Unknown Object (File)
Tue, Jan 21, 12:53 PM
Unknown Object (File)
Tue, Jan 21, 9:24 AM
Unknown Object (File)
Mon, Dec 30, 10:48 PM
Unknown Object (File)
Fri, Dec 27, 3:38 PM
Unknown Object (File)
Tue, Dec 24, 4:28 AM
Unknown Object (File)
Dec 21 2024, 2:47 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T9252: Unprototype Drydock (v1)
Commits
Restricted Diffusion Commit
rP4ac82be5ed22: Merge the DrydockLease workers into a single worker
Summary

Ref T9252. This is the same as D14201, but for lease stuff instead of resource stuff.

This one is a little heavier but still feels pretty reasonable to me at the end of the day (worker is <1K lines and has a ton of comment stuff).

Also fixes a few random bugs I hit in the task queue.

Test Plan
  • Restarted some Harbormaster builds, saw them go through cleanly.
  • Released pre-activation resources/leases.
  • Probably still kinda buggy but I'll iron the details out over time.

Logs are starting to look somewhat plausible:

Screen Shot 2015-09-30 at 2.31.54 PM.png (1×1 px, 269 KB)

Diff Detail

Event Timeline

epriestley updated this revision to Diff 34301.Sep 30 2015, 9:42 PM
epriestley retitled this revision from to Merge the DrydockLease workers into a single worker.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T9252: Unprototype Drydock (v1).
chad accepted this revision.Sep 30 2015, 10:53 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Sep 30 2015, 10:53 PM
Closed by commit rP4ac82be5ed22: Merge the DrydockLease workers into a single worker (authored by epriestley, committed by epriestley). · Explain WhyOct 1 2015, 3:11 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
6 lines
applications/
drydock/
storage/
18 lines
worker/
617 lines
2 lines
harbormaster/
storage/
build/
3 lines
infrastructure/
daemon/
workers/
storage/
5 lines

Diff 34301

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/drydock/storage/DrydockLease.php

Loading...
View Options

src/applications/drydock/worker/DrydockAllocatorWorker.php

Loading...
View Options

src/applications/drydock/worker/DrydockLeaseDestroyWorker.php

Loading...
View Options

src/applications/drydock/worker/DrydockLeaseUpdateWorker.php

Loading...
View Options

src/applications/drydock/worker/DrydockLeaseWorker.php

Loading...
View Options

src/applications/drydock/worker/DrydockWorker.php

Loading...
View Options

src/applications/harbormaster/storage/build/HarbormasterBuildLog.php

Loading...
View Options

src/infrastructure/daemon/workers/storage/PhabricatorWorkerTask.php

Loading...
Phabricator · Built by Phacility