Ref T9252. We're currently resetting to the local branch, but should be resetting to the origin branch.
Details
Details
- Reviewers
chad - Maniphest Tasks
- T9252: Unprototype Drydock (v1)
- Commits
- Restricted Diffusion Commit
rP9d997df9643b: Reset Drydock git working copies better
Restarted a build, had it run git show, saw proper HEAD.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- dd5
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 8097 Build 9223: [Placeholder Plan] Wait for 30 Seconds Build 9222: arc lint + arc unit
Event Timeline
| src/applications/drydock/blueprint/DrydockWorkingCopyBlueprintImplementation.php | ||
|---|---|---|
| 206 | This should git clean -x -d --force --force as discussed elsewhere. | |
Comment Actions
In the Phabricator case, at least, we don't want to -x. If we -x, we remove the phutil library cache, which is otherwise robust and well-behaved, and our build times rise from about 12s to about 600s.
I think "how slowly/thoroughly should the working copy be cleaned" will probably end up as an option on the WorkingCopy blueprint, but for now I'm just hard-coding the most useful behavior for upstream builds.