Page MenuHomePhabricator
Differential D14188

Hide "Revision" column in Diffusion history view if Differential is uninstalled
ClosedPublic
Actions

Authored by epriestley on Sep 29 2015, 1:22 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 25, 3:04 AM
Unknown Object (File)
Sat, Nov 23, 1:04 PM
Unknown Object (File)
Sat, Nov 23, 1:04 PM
Unknown Object (File)
Sat, Nov 23, 1:04 PM
Unknown Object (File)
Thu, Nov 21, 7:49 AM
Unknown Object (File)
Wed, Nov 20, 12:29 PM
Unknown Object (File)
Wed, Nov 20, 11:47 AM
Unknown Object (File)
Wed, Nov 20, 11:47 AM
View All Files
Subscribers
revi

Details

Reviewers
chad
Maniphest Tasks
T9481: Allow 'revision' section in history to be hidden when differential is uninstalled
Commits
Restricted Diffusion Commit
rP6d5c9e897d31: Hide "Revision" column in Diffusion history view if Differential is uninstalled
Summary

Fixes T9481. If the viewer does not have access to Differential (for example, because it is not installed), hide the "Revision" column in Diffusion.

Test Plan
  • Viewed history, saw "Revision" column.
  • Uninstalled Differential, reloaded, no "Revision" column.

Diff Detail

Repository
rP Phabricator
Branch
drevcol
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 8088
Build 9206: [Placeholder Plan] Wait for 30 Seconds
Build 9205: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 34274.Sep 29 2015, 1:22 PM
epriestley retitled this revision from to Hide "Revision" column in Diffusion history view if Differential is uninstalled.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T9481: Allow 'revision' section in history to be hidden when differential is uninstalled.
revi added a subscriber: revi.Sep 29 2015, 1:23 PM
chad accepted this revision.Sep 29 2015, 1:48 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Sep 29 2015, 1:48 PM
Closed by commit rP6d5c9e897d31: Hide "Revision" column in Diffusion history view if Differential is uninstalled (authored by epriestley, committed by epriestley). · Explain WhySep 29 2015, 2:09 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
diffusion/
view/
9 lines

Diff 34274

View Options

src/applications/diffusion/view/DiffusionHistoryTableView.php

Loading...
Phabricator · Built by Phacility