Paths

Table of Contentst

Differential D14187

Allow users to skip "arc:prompt" by entering no text
ClosedPublic
Actions

Authored by epriestley on Sep 29 2015, 11:45 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Jan 24, 9:10 AM

	Unknown Object (File)
	Fri, Jan 24, 9:10 AM

	Unknown Object (File)
	Fri, Jan 24, 9:10 AM

	Unknown Object (File)
	Fri, Jan 24, 9:10 AM

	Unknown Object (File)
	Thu, Jan 23, 2:02 AM

	Unknown Object (File)
	Tue, Jan 21, 10:28 AM

	Unknown Object (File)
	Mon, Jan 20, 1:58 PM

	Unknown Object (File)
	Mon, Jan 20, 1:58 PM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T9476: No way to skip rule arc:prompt

Commits

rARC2df96ed405e2: Allow users to skip "arc:prompt" by entering no text

Summary

Fixes T9476. Currently, if you enter no text in "arc:prompt", we abort resolution immediately.

However, this is a bit inconsistent (other rules that fail to resolve are skipped) it is reasonable to put some default rule behind "arc:prompt" so that you can just mash enter to select it. This construction is unusual, but seems fine and sensible to me.

If you're using "arc:prompt" as the last rule, the behavior is the same as before, so this should only make the rule more useful.

Test Plan

Ran arc which --base 'arc:prompt, git:HEAD^' with and without the patch.
Without the patch, entering no text at "arc:prompt" failed immediately.
With the patch, entering no text caused fallback to the "git:HEAD^" rule.

Diff Detail

Repository

Branch

prompt1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 8087
Build 9204: [Placeholder Plan] Wait for 30 Seconds
Build 9203: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 34273.Sep 29 2015, 11:45 AM

epriestley retitled this revision from to Allow users to skip "arc:prompt" by entering no text.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T9476: No way to skip rule arc:prompt.

epriestley mentioned this in T9476: No way to skip rule arc:prompt.Sep 29 2015, 11:46 AM

chad accepted this revision.Sep 29 2015, 2:02 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Sep 29 2015, 2:02 PM

Closed by commit rARC2df96ed405e2: Allow users to skip "arc:prompt" by entering no text (authored by epriestley, committed by epriestley). · Explain WhySep 29 2015, 2:09 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

parser/

ArcanistBaseCommitParser.php

8 lines

Diff 34273

src/parser/ArcanistBaseCommitParser.php

Loading...