Details

Reviewers

Maniphest Tasks

T9479: If username's initial substring has the same pattern as an object name, it will not be automatically linked by @mention

Commits

Restricted Diffusion Commit
rPfa943f744bc4: Stop all object mentions from matching after "@"

Summary

Fixes T9479. Currently, @aaaaaaaa may try to match as a commit hash, and @C123456 may try to match as a Countdown reference. These should only match as user mentions.

Prevent object mention rules from matching after @. We already prevent them after - and #, and already prevented the username rule after @ (i.e., preventing @@user).

Test Plan

Created some "interesting" users locally and @mentioned them:

Screen Shot 2015-09-29 at 4.08.02 AM.png (582×556 px, 46 KB)

Diff Detail

Repository

rP Phabricator

Branch

objmention

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 8085
Build 9200: [Placeholder Plan] Wait for 30 Seconds
Build 9199: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 34269.Sep 29 2015, 11:10 AM

epriestley retitled this revision from to Stop all object mentions from matching after "@".

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T9479: If username's initial substring has the same pattern as an object name, it will not be automatically linked by @mention.

Slightly more correct patch: [#-@] is a character range which includes more characters than intended.

Use [#@-] instead (which is #, @ and - only).

Add test coverage for the commit reference use case.

epriestley mentioned this in T9479: If username's initial substring has the same pattern as an object name, it will not be automatically linked by @mention.Sep 29 2015, 11:23 AM

Minor consistency tweak to comment.

chad accepted this revision.Sep 29 2015, 1:42 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Sep 29 2015, 1:42 PM

Closed by commit rPfa943f744bc4: Stop all object mentions from matching after "@" (authored by epriestley, committed by epriestley). · Explain WhySep 29 2015, 1:43 PM

This revision was automatically updated to reflect the committed changes.

Stop all object mentions from matching after "@"
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 34271

src/applications/diffusion/remarkup/tests/DiffusionCommitRemarkupRuleTestCase.php

src/infrastructure/markup/rule/PhabricatorObjectRemarkupRule.php

Stop all object mentions from matching after "@"ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 34271

src/applications/diffusion/remarkup/__tests__/DiffusionCommitRemarkupRuleTestCase.php

src/infrastructure/markup/rule/PhabricatorObjectRemarkupRule.php

Stop all object mentions from matching after "@"
ClosedPublic
Actions

Revision Contents
Changeset List

src/applications/diffusion/remarkup/tests/DiffusionCommitRemarkupRuleTestCase.php