Load audit requests when querying audits
ClosedPublic
Actions

Authored by epriestley on Sep 25 2015, 2:50 PM.

Details

Reviewers

chad

Maniphest Tasks

T9434: Conduit Error On audit.query - Attempting to access attached data on PhabricatorRepositoryCommit

Commits

Restricted Diffusion Commit
rPbd546f44a9be: Load audit requests when querying audits

Summary

Fixes T9434. I'm not sure exactly what changed behavior here, but we need a needAuditRequests().

Test Plan

Ran a query which hit the exception (empty query was good enough, locally), then applied this patch; saw exception go away.

Diff Detail

Repository

rP Phabricator

Branch

audit1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 8053
Build 9140: [Placeholder Plan] Wait for 30 Seconds
Build 9139: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 34219.Sep 25 2015, 2:50 PM

epriestley retitled this revision from to Load audit requests when querying audits.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T9434: Conduit Error On audit.query - Attempting to access attached data on PhabricatorRepositoryCommit.

chad accepted this revision.Sep 25 2015, 2:51 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Sep 25 2015, 2:51 PM

Closed by commit rPbd546f44a9be: Load audit requests when querying audits (authored by epriestley, committed by epriestley). · Explain WhySep 25 2015, 5:43 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

audit/

conduit/

AuditQueryConduitAPIMethod.php

3 lines

Diff 34219

View Options

src/applications/audit/conduit/AuditQueryConduitAPIMethod.php

Load audit requests when querying auditsClosedPublicActions