Check that the viewer can actually create badges before letting them create badges
ClosedPublic
Actions

Authored by epriestley on Sep 24 2015, 10:31 PM.

Details

Reviewers

Maniphest Tasks

T9467: Badge creation possible without appropriate permission

Commits

Restricted Diffusion Commit
rP381fa611fd8d: Check that the viewer can actually create badges before letting them create…

Summary

Fixes T9467.

Test Plan

Set policy to "no one", got blocked.

Diff Detail

Repository

rP Phabricator

Branch

badgeperm

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 8049
Build 9131: [Placeholder Plan] Wait for 30 Seconds
Build 9130: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 34213.Sep 24 2015, 10:31 PM

epriestley retitled this revision from to Check that the viewer can actually create badges before letting them create badges.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T9467: Badge creation possible without appropriate permission.

This revision is now accepted and ready to land.Sep 24 2015, 10:33 PM

Closed by commit rP381fa611fd8d: Check that the viewer can actually create badges before letting them create… (authored by epriestley, committed by epriestley). · Explain WhySep 24 2015, 10:34 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

badges/

controller/

PhabricatorBadgesEditController.php

3 lines

Diff 34213

View Options

src/applications/badges/controller/PhabricatorBadgesEditController.php

Check that the viewer can actually create badges before letting them create badgesClosedPublicActions