Page MenuHomePhabricator

Show recent active resources on Drydock blueprint detail, with link to all
ClosedPublic

Authored by epriestley on Sep 24 2015, 8:34 PM.
Tags
None
Referenced Files
F14417420: D14157.diff
Wed, Dec 25, 1:03 AM
Unknown Object (File)
Mon, Dec 16, 4:14 AM
Unknown Object (File)
Sat, Dec 14, 1:43 AM
Unknown Object (File)
Fri, Dec 13, 6:27 PM
Unknown Object (File)
Tue, Dec 10, 1:08 AM
Unknown Object (File)
Wed, Dec 4, 6:18 PM
Unknown Object (File)
Thu, Nov 28, 6:40 PM
Unknown Object (File)
Thu, Nov 28, 12:45 AM
Subscribers
None

Details

Summary

Ref T9252. Currently, Drydock blueprint pages:

  • show all resources, even if there are a million;
  • show resources in all states, although destroyed resources are usually uninteresting;
  • have some junky $pager code.

Instead, show the few most recent active resources and link to a filtered resource view in ApplicationSearch.

Test Plan
  • Viewed some blueprints.
  • Clicked "View All Resources".
  • Saw all resources.
  • Used query / crumbs / etc.

Diff Detail

Repository
rP Phabricator
Branch
drydock12
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 8045
Build 9122: [Placeholder Plan] Wait for 30 Seconds
Build 9121: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Show recent active resources on Drydock blueprint detail, with link to all.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
chad added inline comments.
src/applications/drydock/controller/DrydockBlueprintViewController.php
161

You can just setIconFont directly on ButtonView

This revision is now accepted and ready to land.Sep 24 2015, 8:43 PM
This revision was automatically updated to reflect the committed changes.