Page MenuHomePhabricator

Soften checks on a very old Maniphest transactionmigration
ClosedPublic

Authored by epriestley on Sep 24 2015, 1:43 AM.
Tags
None
Referenced Files
F13289587: D14149.id.diff
Tue, Jun 4, 1:06 PM
F13289586: D14149.diff
Tue, Jun 4, 1:06 PM
F13280953: D14149.diff
Sun, Jun 2, 9:30 AM
F13267763: D14149.diff
Wed, May 29, 4:12 AM
F13260342: D14149.id34190.diff
Sun, May 26, 11:47 PM
F13253208: D14149.diff
Sat, May 25, 2:29 AM
F13231626: D14149.diff
Tue, May 21, 12:37 AM
F13228619: D14149.id.diff
Mon, May 20, 10:46 AM
Subscribers
None

Details

Summary

Ref T9464. If an ancient transaction doesn't have array values for whatever reason, we fail here.

Instead, just recover as gracefully as we can. We may get the transaction "wrong" in some sense, but this only impacts what is rendered in the transaction log.

Test Plan

This is nearly a year old and there's no real way to test it.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Soften checks on a very old Maniphest transactionmigration.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
This revision is now accepted and ready to land.Sep 24 2015, 1:44 AM
This revision was automatically updated to reflect the committed changes.