Ref T9252. Some leases or resources may need to remove data, tear down VMs, etc., during cleanup. After they are released, queue a "destroy" phase for performing teardown.
Details
Details
- Reviewers
hach-que chad - Maniphest Tasks
- T6569: Implement proper expiry mechanism for Drydock resources
T9252: Unprototype Drydock (v1) - Commits
- Restricted Diffusion Commit
rP1f311d64c608: Give Drydock resources and leases a real "destroy" lifecycle phase
- Used bin/drydock lease ... to create a working copy lease.
- Used bin/drydock release-lease and bin/drydock release-resource to release the lease and then the working copy and host.
- Saw working copy and host get destroyed and cleaned up properly.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- drydock2
- Lint
Lint Passed Severity Location Code Message Advice src/applications/drydock/worker/DrydockLeaseDestroyWorker.php:32 XHP16 TODO Comment - Unit
Tests Passed - Build Status
Buildable 8028 Build 9086: [Placeholder Plan] Wait for 30 Seconds Build 9085: arc lint + arc unit