Make icon setting in Section Headers easier/consistent
ClosedPublic
Actions

Authored by chad on Sep 19 2015, 4:52 PM.

Tags

None

Referenced Files

	F18053325: D14131.id34134.diff
	Mon, Aug 4, 4:31 AM

	F18050317: D14131.id34136.diff
	Sun, Aug 3, 7:22 PM

	F18043325: D14131.id34135.diff
	Sun, Aug 3, 5:45 AM

	F18004973: D14131.id34135.diff
	Sat, Aug 2, 12:50 PM

	F17991119: D14131.id34134.diff
	Sat, Aug 2, 1:03 AM

	F17986394: D14131.id.diff
	Fri, Aug 1, 9:21 PM

	F17951128: D14131.diff
	Fri, Aug 1, 1:00 AM

	F17899380: D14131.diff
	Tue, Jul 29, 8:37 AM

View All Files

Subscribers

Korvin

Details

Reviewers

epriestley

Commits

Restricted Diffusion Commit
rP666f19e50491: Make icon setting in Section Headers easier/consistent

Summary

You can already pass other icons, but this makes it a bit simpler.

Test Plan

Test Maniphest, Badges

Diff Detail

Repository

rP Phabricator

Branch

prop-icon

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 8008
Build 9046: [Placeholder Plan] Wait for 30 Seconds
Build 9045: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 34134.Sep 19 2015, 4:52 PM

chad retitled this revision from to Make icon setting in Section Headers easier/consistent.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

Herald added a subscriber: Korvin. · View Herald TranscriptSep 19 2015, 4:52 PM

add missing icons

epriestley accepted this revision.Sep 19 2015, 6:10 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Sep 19 2015, 6:10 PM

Closed by commit rP666f19e50491: Make icon setting in Section Headers easier/consistent (authored by chad, committed by chad). · Explain WhySep 19 2015, 6:29 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

view/

phui/

PHUIPropertyListView.php

6 lines

Diff 34134

View Options

src/view/phui/PHUIPropertyListView.php

Make icon setting in Section Headers easier/consistentClosedPublicActions