Page MenuHomePhabricator
Differential D14099

Implement Cowsay in PHP
ClosedPublic
Actions

Authored by epriestley on Sep 13 2015, 4:23 PM.
Tags
None
Referenced Files
F13296861: D14099.id34077.diff
Thu, Jun 6, 8:56 PM
F13285162: D14099.id34083.diff
Mon, Jun 3, 4:12 PM
F13277762: D14099.id34078.diff
Fri, May 31, 12:55 PM
F13277761: D14099.id34077.diff
Fri, May 31, 12:55 PM
F13253561: D14099.id34083.diff
Sat, May 25, 2:45 AM
F13239680: D14099.id.diff
Wed, May 22, 5:36 AM
F13235893: D14099.diff
Tue, May 21, 7:01 AM
F13218736: D14099.id.diff
Sat, May 18, 1:14 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T9408: Upgrading: `dot` (Graphviz) support removed, changes to `figlet` and `cowsay`
T7785: Build a Phacility cluster service tier to sandbox Graphviz and Cowsay
Commits
rPHU0c7b526c9eeb: (stable) Promote 2015 Week 38
rPHU880c0fb3448f: Implement Cowsay in PHP
Summary

Ref T7785. This provides a safe implementation of the cowsay templater.

Test Plan

Added a unit test.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 34077.Sep 13 2015, 4:23 PM
epriestley retitled this revision from to Implement Cowsay in PHP.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T7785: Build a Phacility cluster service tier to sandbox Graphviz and Cowsay.
epriestley updated this revision to Diff 34078.Sep 13 2015, 4:49 PM
  • Strip Perl comments.
  • Pad eyes and tongue to 2 characters.
chad accepted this revision.Sep 13 2015, 7:21 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Sep 13 2015, 7:21 PM
epriestley added a task: T9408: Upgrading: `dot` (Graphviz) support removed, changes to `figlet` and `cowsay`.Sep 13 2015, 7:26 PM
Closed by commit rPHU880c0fb3448f: Implement Cowsay in PHP (authored by epriestley, committed by epriestley). · Explain WhySep 13 2015, 7:27 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
4 lines
utils/
135 lines
__tests__/
60 lines
cowsay/
12 lines
15 lines

Diff 34083

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/utils/PhutilCowsay.php

Loading...
View Options

src/utils/__tests__/PhutilCowsayTestCase.php

Loading...
View Options

src/utils/__tests__/cowsay/cube.expect

Loading...
View Options

src/utils/__tests__/cowsay/cube.test

Loading...
Phabricator · Built by Phacility