Page MenuHomePhabricator
Differential D14097

Revert "Allow search results to be snippeted, roughly"
ClosedPublic
Actions

Authored by epriestley on Sep 11 2015, 3:55 AM.
Tags
None
Referenced Files
F13282453: D14097.diff
Sun, Jun 2, 12:05 PM
F13267837: D14097.diff
Wed, May 29, 4:18 AM
F13253300: D14097.diff
Sat, May 25, 2:34 AM
F13231784: D14097.diff
Tue, May 21, 12:46 AM
F13226604: D14097.diff
Sun, May 19, 9:51 PM
F13210754: D14097.diff
Fri, May 17, 5:11 AM
F13198981: D14097.diff
Mon, May 13, 10:47 AM
F13194686: D14097.diff
Sun, May 12, 9:47 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Commits
Restricted Diffusion Commit
rP1c45a7d8e2c5: Revert "Allow search results to be snippeted, roughly"
Summary

This reverts commit 15837388428d6dd3c37cf4b1d302e78657fce24e.

See T8646 for discussion. This version of the feature feels terrible on real data.

Test Plan

Strict revert.

Diff Detail

Repository
rP Phabricator
Branch
revert
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7966
Build 8961: [Placeholder Plan] Wait for 30 Seconds
Build 8960: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 34073.Sep 11 2015, 3:55 AM
epriestley retitled this revision from to Revert "Allow search results to be snippeted, roughly".
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
Herald edited edge metadata. · View Herald TranscriptSep 11 2015, 3:55 AM
chad accepted this revision.Sep 11 2015, 3:56 AM
chad edited edge metadata.
This revision is now accepted and ready to land.Sep 11 2015, 3:56 AM
Closed by commit rP1c45a7d8e2c5: Revert "Allow search results to be snippeted, roughly" (authored by epriestley, committed by epriestley). · Explain WhySep 11 2015, 3:57 AM
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in T8646: Provide more context for search results, particularly wiki documents.Sep 11 2015, 4:00 AM
epriestley mentioned this in D14095: Allow search results to be snippeted, roughly.Sep 11 2015, 4:28 AM

Revision Contents
Changeset List

PathSize
resources/
celerity/
4 lines
src/
4 lines
applications/
differential/
storage/
17 lines
maniphest/
storage/
17 lines
phriction/
storage/
18 lines
search/
interface/
query/
1 line
view/
18 lines
webroot/
rsrc/
css/
application/
search/
5 lines

Diff 34073

View Options

resources/celerity/map.php

Loading...
View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/differential/storage/DifferentialRevision.php

Loading...
View Options

src/applications/maniphest/storage/ManiphestTask.php

Loading...
View Options

src/applications/phriction/storage/PhrictionDocument.php

Loading...
View Options

src/applications/search/interface/PhabricatorSearchSnippetInterface.php

Loading...
View Options

src/applications/search/query/PhabricatorSearchApplicationSearchEngine.php

Loading...
View Options

src/applications/search/view/PhabricatorSearchResultView.php

Loading...
View Options

webroot/rsrc/css/application/search/search-results.css

Loading...
Phabricator · Built by Phacility