Page MenuHomePhabricator
Differential D14079

Provide an AphrontController implementation of willSendResponse()
ClosedPublic
Actions

Authored by epriestley on Sep 8 2015, 12:14 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jan 27, 3:14 AM
Unknown Object (File)
Mon, Jan 27, 3:14 AM
Unknown Object (File)
Sun, Jan 26, 11:30 PM
Unknown Object (File)
Fri, Jan 24, 8:56 AM
Unknown Object (File)
Fri, Jan 24, 8:56 AM
Unknown Object (File)
Fri, Jan 24, 8:56 AM
Unknown Object (File)
Tue, Jan 21, 10:01 AM
Unknown Object (File)
Sat, Jan 18, 8:01 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Commits
Restricted Diffusion Commit
rP6915011067d6: Provide an AphrontController implementation of willSendResponse()
Summary

This is required by Aphront now but not given a default implementation in the base class.

Test Plan

CORGI sites now work.

Diff Detail

Repository
rP Phabricator
Branch
willsend
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7939
Build 8907: [Placeholder Plan] Wait for 30 Seconds
Build 8906: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 34026.Sep 8 2015, 12:14 AM
epriestley retitled this revision from to Provide an AphrontController implementation of willSendResponse().
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
Herald edited edge metadata. · View Herald TranscriptSep 8 2015, 12:14 AM
chad accepted this revision.Sep 8 2015, 12:18 AM
chad edited edge metadata.
This revision is now accepted and ready to land.Sep 8 2015, 12:18 AM
Closed by commit rP6915011067d6: Provide an AphrontController implementation of willSendResponse() (authored by epriestley, committed by epriestley). · Explain WhySep 8 2015, 12:18 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
10 lines
src/
aphront/
4 lines
webroot/
rsrc/
css/
aphront/
2 lines

Diff 34026

View Options

resources/celerity/map.php

Loading...
View Options

src/aphront/AphrontController.php

Loading...
View Options

webroot/rsrc/css/aphront/list-filter-view.css

Loading...
Phabricator · Built by Phacility