Page MenuHomePhabricator

Fix abrupt failure mode for uncloned repositories in Diffusion
ClosedPublic

Authored by epriestley on Sep 3 2015, 10:50 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Dec 18, 7:02 AM
Unknown Object (File)
Thu, Dec 12, 6:30 PM
Unknown Object (File)
Thu, Dec 12, 12:10 AM
Unknown Object (File)
Sat, Dec 7, 5:35 PM
Unknown Object (File)
Sun, Nov 24, 6:43 AM
Unknown Object (File)
Sat, Nov 23, 7:56 PM
Unknown Object (File)
Nov 18 2024, 8:48 PM
Unknown Object (File)
Nov 1 2024, 8:25 PM
Subscribers
None

Details

Summary

Fixes T9080. We try to list alternatives for the current ref (for example, if you're viewing a branch named "master" but there's also a tag named "master", or, in Mercurial, there are several branches named "master") but fail to abruptly if we can't get the list.

It's fine if we can't get the list; just continue. This is common when the repository hasn't cloned yet.

Test Plan

In a local repository with bad credentials, tried to do anything before and after. Before: completely blocked by error; after: things work normally.

Diff Detail

Repository
rP Phabricator
Branch
commit1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7893
Build 8817: [Placeholder Plan] Wait for 30 Seconds
Build 8816: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Fix abrupt failure mode for uncloned repositories in Difufsion.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad retitled this revision from Fix abrupt failure mode for uncloned repositories in Difufsion to Fix abrupt failure mode for uncloned repositories in Diffusion.
chad edited edge metadata.
This revision is now accepted and ready to land.Sep 3 2015, 3:20 PM
This revision was automatically updated to reflect the committed changes.