Page MenuHomePhabricator
Differential D14018

Break long strings in all remarkup areas
ClosedPublic
Actions

Authored by chad on Aug 31 2015, 7:59 PM.
Tags
None
Referenced Files
F14044092: D14018.diff
Tue, Nov 12, 2:47 PM
F14030121: D14018.id.diff
Sat, Nov 9, 12:10 AM
F14030070: D14018.id33976.diff
Fri, Nov 8, 11:46 PM
F14030066: D14018.id33900.diff
Fri, Nov 8, 11:44 PM
F14029422: D14018.id33901.diff
Fri, Nov 8, 8:41 PM
F14022215: D14018.id33976.diff
Wed, Nov 6, 3:44 PM
F14022213: D14018.id33900.diff
Wed, Nov 6, 3:44 PM
F14022212: D14018.id.diff
Wed, Nov 6, 3:44 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T9264: Ponder Question/Answer on Mobile display is not able to horizontally scroll
Commits
Restricted Diffusion Commit
rP42ed5241204d: Break long strings in all remarkup areas
Summary

Fixes T9264. I'm surprised this hasn't come up before, but any long string or URL in remarkup will overflow and cause remarkup areas to scroll. Prefer breaking these words.

Test Plan

Review a timeline feed in Differential and a Ponder answer.

pasted_file (423×283 px, 69 KB)

Diff Detail

Repository
rP Phabricator
Branch
break-word
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7859
Build 8749: [Placeholder Plan] Wait for 30 Seconds
Build 8748: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 33900.Aug 31 2015, 7:59 PM
chad retitled this revision from to Break long strings in all remarkup areas.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
chad added a task: T9264: Ponder Question/Answer on Mobile display is not able to horizontally scroll.
Herald added a subscriber: Korvin. · View Herald TranscriptAug 31 2015, 7:59 PM
chad edited the test plan for this revision. (Show Details)Aug 31 2015, 8:00 PM
chad updated this revision to Diff 33901.Aug 31 2015, 8:01 PM
  • should be break-word
chad edited the test plan for this revision. (Show Details)Aug 31 2015, 8:02 PM
epriestley accepted this revision.Sep 3 2015, 2:15 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Sep 3 2015, 2:15 PM
Closed by commit rP42ed5241204d: Break long strings in all remarkup areas (authored by chad, committed by chad). · Explain WhySep 3 2015, 6:03 PM
This revision was automatically updated to reflect the committed changes.
Pawka mentioned this in T9522: CSS rule "word-break: break-word" breaks line numbers on innline pastes and table headers on phriction documents.Oct 7 2015, 7:33 AM

Revision Contents
Changeset List

PathSize
resources/
celerity/
6 lines
webroot/
rsrc/
css/
core/
1 line

Diff 33900

View Options

resources/celerity/map.php

Loading...
View Options

webroot/rsrc/css/core/remarkup.css

Loading...
Phabricator · Built by Phacility