Page MenuHomePhabricator

[drydock/core] Allow transient leases to be leased even if the resource is at it's maximum lease limit
AbandonedPublic

Authored by hach-que on Jul 1 2015, 11:41 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Dec 2, 6:10 PM
Unknown Object (File)
Wed, Nov 27, 7:24 PM
Unknown Object (File)
Mon, Nov 25, 9:46 AM
Unknown Object (File)
Tue, Nov 19, 11:05 PM
Unknown Object (File)
Nov 16 2024, 4:21 AM
Unknown Object (File)
Nov 12 2024, 4:30 AM
Unknown Object (File)
Nov 8 2024, 7:08 AM
Unknown Object (File)
Oct 18 2024, 12:26 PM
Subscribers

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T2015: Implement Drydock
Summary

Ref T2015. This allows transient leases to be acquired on a resource where the blueprint implements min/max/expiry logic, as transient leases will not keep the resource open any way.

This corrects the scenario where a resource has a maximum of 1 lease, and a working copy is attempted to be obtained against that resource. If the working copy cache blueprint is enabled, then it will always fail without this patch because of the maximum of 1 lease. It is undesirable to set the maximum to 2, because we don't want to permit more than one build to run on the same host resource.

Test Plan

N/A

Diff Detail

Repository
rP Phabricator
Branch
hachque-reconstructed
Lint
Lint Passed
Unit
Tests Skipped
Build Status
Buildable 7787
Build 8606: [Placeholder Plan] Wait for 30 Seconds
Build 8605: arc lint + arc unit

Event Timeline

hach-que retitled this revision from to [drydock/core] Allow transient leases to be leased even if the resource is at it's maximum lease limit.
hach-que updated this object.
hach-que edited the test plan for this revision. (Show Details)
hach-que added a reviewer: epriestley.