Tags

None

Referenced Files

	F18644048: D13506.diff
	Fri, Sep 19, 4:13 AM

	F18621023: D13506.id32694.diff
	Mon, Sep 15, 6:54 AM

	F18597324: D13506.id32693.diff
	Sat, Sep 13, 2:35 AM

	F18506093: D13506.id.diff
	Fri, Sep 5, 1:11 AM

	F18498616: D13506.diff
	Thu, Sep 4, 6:53 PM

	F18199875: D13506.id32693.diff
	Aug 18 2025, 2:50 AM

	F17942739: D13506.id.diff
	Jul 31 2025, 7:06 AM

	F17940496: D13506.id.diff
	Jul 31 2025, 4:28 AM

View All Files

Subscribers

epriestley

Korvin

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T1049: Implement Harbormaster
T2015: Implement Drydock

Summary

Ref T1049. Ref T2015. This implements build steps that can lease working copies from various sources, including:

The current buildable
A custom external repository URL and ref
A hosted repository and ref

Test Plan

Created a Harbormaster build with these build steps and ran the build.

Diff Detail

Repository

rP Phabricator

Branch

hachque-reconstructed

Lint

Lint Passed

Severity	Location	Code	Message
Advice	src/applications/harbormaster/step/HarbormasterLeaseWorkingCopyBuildStepImplementation.php:42	XHP16	TODO Comment

Unit

Tests Skipped

Build Status

Buildable 7784
Build 8600: [Placeholder Plan] Wait for 30 Seconds
Build 8599: arc lint + arc unit

Event Timeline

hach-que updated this revision to Diff 32662.Jul 1 2015, 4:39 AM

hach-que retitled this revision from to [harbormaster/working-copies/v0] Implement lease working copy build steps.

hach-que updated this object.

hach-que edited the test plan for this revision. (Show Details)

hach-que added a reviewer: epriestley.

hach-que added tasks: T2015: Implement Drydock, T1049: Implement Harbormaster.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJul 1 2015, 4:39 AM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

hach-que mentioned this in D13507: [drydock/working-copies/v1-caching] Implement working copy cache blueprint.Jul 1 2015, 4:45 AM

Add git fetch for diff tags

Add git fetch for diff tags

Rebase

Update to use new Harbormaster artifact constants

hach-que abandoned this revision.Dec 3 2015, 9:43 AM

[harbormaster/working-copies/v0] Implement lease working copy build steps
AbandonedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 33779

src/__phutil_library_map__.php

src/applications/drydock/blueprint/DrydockWorkingCopyBlueprintImplementation.php

src/applications/harbormaster/customfield/HarbormasterCustomFieldRepository.php

src/applications/harbormaster/step/HarbormasterLeaseWorkingCopyBuildStepImplementation.php

src/applications/harbormaster/step/HarbormasterLeaseWorkingCopyFromBuildableBuildStepImplementation.php

src/applications/harbormaster/step/HarbormasterLeaseWorkingCopyFromRepositoryBuildStepImplementation.php

src/applications/harbormaster/step/HarbormasterLeaseWorkingCopyFromURLBuildStepImplementation.php

[harbormaster/working-copies/v0] Implement lease working copy build stepsAbandonedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 33779

src/__phutil_library_map__.php

src/applications/drydock/blueprint/DrydockWorkingCopyBlueprintImplementation.php

src/applications/harbormaster/customfield/HarbormasterCustomFieldRepository.php

src/applications/harbormaster/step/HarbormasterLeaseWorkingCopyBuildStepImplementation.php

src/applications/harbormaster/step/HarbormasterLeaseWorkingCopyFromBuildableBuildStepImplementation.php

src/applications/harbormaster/step/HarbormasterLeaseWorkingCopyFromRepositoryBuildStepImplementation.php

src/applications/harbormaster/step/HarbormasterLeaseWorkingCopyFromURLBuildStepImplementation.php

[harbormaster/working-copies/v0] Implement lease working copy build steps
AbandonedPublic
Actions

Revision Contents
Changeset List