Page MenuHomePhabricator
Differential D13956

Add a "Startup" to DarkConsole
ClosedPublic
Actions

Authored by epriestley on Aug 21 2015, 5:47 PM.
Tags
None
Referenced Files
F14781096: D13956.id33689.diff
Fri, Jan 24, 8:22 AM
F14781095: D13956.id33686.diff
Fri, Jan 24, 8:22 AM
Unknown Object (File)
Tue, Jan 21, 7:38 PM
Unknown Object (File)
Tue, Jan 21, 11:15 AM
Unknown Object (File)
Fri, Jan 17, 8:32 PM
Unknown Object (File)
Tue, Jan 14, 3:53 AM
Unknown Object (File)
Tue, Jan 14, 3:42 AM
Unknown Object (File)
Fri, Dec 27, 7:41 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T8588: One instance has a severe, global performance issue
Commits
Restricted Diffusion Commit
rP4b1815d6cca2: Add a "Startup" to DarkConsole
Summary

Ref T8588. It looks like something slow is happening before we start DarkConsole. Add some crude reporting to try to narrow it down.

Test Plan

Screen Shot 2015-08-21 at 10.23.12 AM.png (761×1 px, 113 KB)

Diff Detail

Repository
rP Phabricator
Branch
startup
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesupport/PhabricatorStartup.php:39PHLXHP6Class Not Extending Phobject
Unit
Tests Passed
Build Status
Buildable 7712
Build 8459: [Placeholder Plan] Wait for 30 Seconds
Build 8458: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 33686.Aug 21 2015, 5:47 PM
epriestley retitled this revision from to Add a "Startup" to DarkConsole.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T8588: One instance has a severe, global performance issue.
chad accepted this revision.Aug 21 2015, 7:05 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Aug 21 2015, 7:05 PM
Closed by commit rP4b1815d6cca2: Add a "Startup" to DarkConsole (authored by epriestley, committed by epriestley). · Explain WhyAug 21 2015, 9:53 PM
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in T8588: One instance has a severe, global performance issue.Aug 21 2015, 11:10 PM

Revision Contents
Changeset List

PathSize
src/
2 lines
aphront/
configuration/
8 lines
applications/
console/
plugin/
84 lines
xhprof/
20 lines
docs/
user/
field/
19 lines
support/
64 lines
webroot/
37 lines

Diff 33686

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/aphront/configuration/AphrontApplicationConfiguration.php

Loading...
View Options

src/applications/console/plugin/DarkConsoleStartupPlugin.php

Loading...
View Options

src/applications/console/plugin/xhprof/DarkConsoleXHProfPluginAPI.php

Loading...
View Options

src/docs/user/field/darkconsole.diviner

Loading...
View Options

support/PhabricatorStartup.php

Loading...
View Options

webroot/index.php

Loading...
Phabricator · Built by Phacility