Paths

Table of Contentst

Differential D13953

Fix Ponder Answer query joins, builtins
ClosedPublic
Actions

Authored by chad on Aug 21 2015, 4:47 AM.

Details

Reviewers

epriestley

Maniphest Tasks

T9234: Ponder query by "Answered by" gives unexpected results

Commits

Restricted Diffusion Commit
rPad93af83891d: Fix Ponder Answer query joins, builtins

Summary

Fixes T9234. The joins method was still the old method and the builtin was calling the wrong key.

Test Plan

Test authored builtin, custom search

Diff Detail

Repository

rP Phabricator

Branch

ponder-answer-search

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 7706
Build 8449: [Placeholder Plan] Wait for 30 Seconds
Build 8448: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 33676.Aug 21 2015, 4:47 AM

chad retitled this revision from to Fix Ponder Answer query joins, builtins.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

chad added a task: T9234: Ponder query by "Answered by" gives unexpected results.

Herald added a subscriber: Korvin. · View Herald TranscriptAug 21 2015, 4:47 AM

epriestley accepted this revision.Aug 21 2015, 10:56 AM

epriestley edited edge metadata.

epriestley added inline comments.

src/applications/ponder/query/PonderQuestionQuery.php
144	I'd expect this to just be `return $joins;` now.

This revision is now accepted and ready to land.Aug 21 2015, 10:56 AM

per comments

Closed by commit rPad93af83891d: Fix Ponder Answer query joins, builtins (authored by chad, committed by chad). · Explain WhyAug 21 2015, 1:58 PM

This revision was automatically updated to reflect the committed changes.

chad marked an inline comment as done.

Revision Contents
Changeset List

Path

Size

src/

applications/

ponder/

query/

PonderQuestionQuery.php

2 lines

PonderQuestionSearchEngine.php

2 lines

Diff 33676

View Options

src/applications/ponder/query/PonderQuestionQuery.php