Page MenuHomePhabricator
Differential D13936

Remove Files Widget from Conpherence
ClosedPublic
Actions

Authored by chad on Aug 19 2015, 3:21 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 22, 4:15 AM
Unknown Object (File)
Thu, Dec 12, 5:58 AM
Unknown Object (File)
Thu, Dec 5, 9:45 PM
Unknown Object (File)
Thu, Dec 5, 2:20 AM
Unknown Object (File)
Wed, Dec 4, 8:10 PM
Unknown Object (File)
Wed, Dec 4, 5:44 AM
Unknown Object (File)
Tue, Dec 3, 4:50 PM
Unknown Object (File)
Tue, Dec 3, 4:50 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T8834: Remove Calendar/Files from Conpherence
Commits
Restricted Diffusion Commit
rP167eb9a25692: Remove Files Widget from Conpherence
Summary

Fixes T8834. Removes everywhere I could find references to Files.

Test Plan

Use Conpherence, send a message, attach a file, try durable column, send message, send file. Seems snappy.

Diff Detail

Repository
rP Phabricator
Branch
conpherence-redesign-2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7681
Build 8399: [Placeholder Plan] Wait for 30 Seconds
Build 8398: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 33637.Aug 19 2015, 3:21 AM
chad retitled this revision from to Remove Files Widget from Conpherence.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
chad added a task: T8834: Remove Calendar/Files from Conpherence.
Herald added a subscriber: Korvin. · View Herald TranscriptAug 19 2015, 3:21 AM
chad updated this revision to Diff 33638.Aug 19 2015, 3:29 AM
  • foo
epriestley accepted this revision.Aug 20 2015, 12:35 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Aug 20 2015, 12:35 PM
Closed by commit rP167eb9a25692: Remove Files Widget from Conpherence (authored by chad, committed by chad). · Explain WhyAug 20 2015, 3:24 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
36 lines
src/
2 lines
applications/
conpherence/
constants/
6 lines
controller/
7 lines
18 lines
view/
webroot/
rsrc/
css/
application/
conpherence/
63 lines
js/
application/
conpherence/
12 lines

Diff 33638

View Options

resources/celerity/map.php

Loading...
View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/conpherence/constants/ConpherenceWidgetConfigConstants.php

Loading...
View Options

src/applications/conpherence/controller/ConpherenceUpdateController.php

Loading...
View Options

src/applications/conpherence/controller/ConpherenceWidgetController.php

Loading...
View Options

src/applications/conpherence/view/ConpherenceFileWidgetView.php

Loading...
View Options

webroot/rsrc/css/application/conpherence/widget-pane.css

Loading...
View Options

webroot/rsrc/js/application/conpherence/behavior-menu.js

Loading...
Phabricator · Built by Phacility