Page MenuHomePhabricator
Differential D13932

Remove call to loadDrydockLease
ClosedPublic
Actions

Authored by chad on Aug 18 2015, 11:37 PM.
Tags
None
Referenced Files
F15578937: D13932.id33628.diff
Tue, May 6, 9:46 PM
F15546289: D13932.diff
Sat, Apr 26, 2:51 PM
F15491275: D13932.id33629.diff
Sat, Apr 12, 1:14 AM
F15482731: D13932.id33629.diff
Wed, Apr 9, 7:34 AM
F15435828: D13932.id33630.diff
Mar 25 2025, 10:27 AM
F15396136: D13932.id33629.diff
Mar 16 2025, 12:10 PM
F15389068: D13932.diff
Mar 15 2025, 4:51 AM
F15293856: D13932.diff
Mar 5 2025, 5:12 AM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T9219: 'Exception' with message 'Unable to resolve method 'loadDrydockLease'.'
Commits
Restricted Diffusion Commit
rPa1d1cf77a788: Remove call to loadDrydockLease
Summary

Fixes T9219... I think.

Test Plan

swagging a guess for epriestley

Diff Detail

Repository
rP Phabricator
Branch
harbormaster
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7674
Build 8385: [Placeholder Plan] Wait for 30 Seconds
Build 8384: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 33628.Aug 18 2015, 11:37 PM
chad retitled this revision from to Remove call to loadDrydockLease.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
chad added a task: T9219: 'Exception' with message 'Unable to resolve method 'loadDrydockLease'.'.
Herald added a subscriber: Korvin. · View Herald TranscriptAug 18 2015, 11:37 PM
epriestley requested changes to this revision.Aug 18 2015, 11:43 PM
epriestley edited edge metadata.
epriestley added inline comments.
src/applications/harbormaster/step/HarbormasterUploadArtifactBuildStepImplementation.php
49

I think pull this out as $viewer and pass it to loadArtifactLease too, then you're good to go.

This revision now requires changes to proceed.Aug 18 2015, 11:43 PM
chad updated this revision to Diff 33629.Aug 19 2015, 12:44 AM
chad edited edge metadata.
  • comment
chad marked an inline comment as done.Aug 19 2015, 12:45 AM
epriestley accepted this revision.Aug 19 2015, 12:52 AM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Aug 19 2015, 12:52 AM
Closed by commit rPa1d1cf77a788: Remove call to loadDrydockLease (authored by chad, committed by chad). · Explain WhyAug 19 2015, 12:52 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
harbormaster/
step/
6 lines

Diff 33629

View Options

src/applications/harbormaster/step/HarbormasterUploadArtifactBuildStepImplementation.php

Loading...
Phabricator · Built by Phacility