Page MenuHomePhabricator
Differential D13932

Remove call to loadDrydockLease
ClosedPublic
Actions

Authored by chad on Aug 18 2015, 11:37 PM.
Tags
None
Referenced Files
F14068167: D13932.diff
Tue, Nov 19, 8:08 PM
F14055250: D13932.diff
Sat, Nov 16, 9:50 AM
F14045790: D13932.diff
Wed, Nov 13, 11:14 AM
F14041864: D13932.diff
Mon, Nov 11, 10:16 PM
F14031267: D13932.id33630.diff
Sat, Nov 9, 9:55 AM
F14031266: D13932.id33629.diff
Sat, Nov 9, 9:55 AM
F14031265: D13932.id33628.diff
Sat, Nov 9, 9:55 AM
F14031264: D13932.id.diff
Sat, Nov 9, 9:54 AM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T9219: 'Exception' with message 'Unable to resolve method 'loadDrydockLease'.'
Commits
Restricted Diffusion Commit
rPa1d1cf77a788: Remove call to loadDrydockLease
Summary

Fixes T9219... I think.

Test Plan

swagging a guess for epriestley

Diff Detail

Repository
rP Phabricator
Branch
harbormaster
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7674
Build 8385: [Placeholder Plan] Wait for 30 Seconds
Build 8384: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 33628.Aug 18 2015, 11:37 PM
chad retitled this revision from to Remove call to loadDrydockLease.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
chad added a task: T9219: 'Exception' with message 'Unable to resolve method 'loadDrydockLease'.'.
Herald added a subscriber: Korvin. · View Herald TranscriptAug 18 2015, 11:37 PM
epriestley requested changes to this revision.Aug 18 2015, 11:43 PM
epriestley edited edge metadata.
epriestley added inline comments.
src/applications/harbormaster/step/HarbormasterUploadArtifactBuildStepImplementation.php
49

I think pull this out as $viewer and pass it to loadArtifactLease too, then you're good to go.

This revision now requires changes to proceed.Aug 18 2015, 11:43 PM
chad updated this revision to Diff 33629.Aug 19 2015, 12:44 AM
chad edited edge metadata.
  • comment
chad marked an inline comment as done.Aug 19 2015, 12:45 AM
epriestley accepted this revision.Aug 19 2015, 12:52 AM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Aug 19 2015, 12:52 AM
Closed by commit rPa1d1cf77a788: Remove call to loadDrydockLease (authored by chad, committed by chad). · Explain WhyAug 19 2015, 12:52 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
harbormaster/
step/
6 lines

Diff 33629

View Options

src/applications/harbormaster/step/HarbormasterUploadArtifactBuildStepImplementation.php

Loading...
Phabricator · Built by Phacility