Differential D13924

Sort Ponder Answers by voteCount
ClosedPublic
Actions

Authored by chad on Aug 17 2015, 5:43 PM.

Details

Reviewers

epriestley

Maniphest Tasks

T9207: Sort Ponder Answers by helpfuls

Commits

Restricted Diffusion Commit
rPbd0bbc713a36: Sort Ponder Answers by voteCount

Summary

Fixes T9207. I think this is correct? Sorts based on vote count and reverses the order of the array so higher is first.

Test Plan

Test vote ordering on a number of sample tasks.

Diff Detail

Repository

rP Phabricator

Branch

answers-sort

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 7661
Build 8360: [Placeholder Plan] Wait for 30 Seconds
Build 8359: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 33605.Aug 17 2015, 5:43 PM

chad retitled this revision from to Sort Ponder Answers by voteCount.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

chad added a task: T9207: Sort Ponder Answers by helpfuls.

Herald added a subscriber: Korvin. · View Herald TranscriptAug 17 2015, 5:43 PM

epriestley accepted this revision.Aug 17 2015, 6:32 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Aug 17 2015, 6:32 PM

Closed by commit rPbd0bbc713a36: Sort Ponder Answers by voteCount (authored by chad, committed by chad). · Explain WhyAug 17 2015, 6:48 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

ponder/

controller/

PonderQuestionViewController.php

3 lines

Diff 33605

View Options

src/applications/ponder/controller/PonderQuestionViewController.php

Sort Ponder Answers by voteCountClosedPublicActions