Differential D13914

Fix mobile previous revision inline comments
ClosedPublic
Actions

Authored by chad on Aug 15 2015, 10:21 PM.

Details

Reviewers

epriestley

Maniphest Tasks

T9016: Weird CSS issue with inline comments

Commits

Restricted Diffusion Commit
rPc9de213750c1: Fix mobile previous revision inline comments

Summary

Fixes T9016, adds additonal space around icons.

Test Plan

Visit an old inline comment, no overlapping icon.

Diff Detail

Repository

rP Phabricator

Branch

inline-comment-mobile

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 7650
Build 8338: [Placeholder Plan] Wait for 30 Seconds
Build 8337: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 33580.Aug 15 2015, 10:21 PM

chad retitled this revision from to Fix mobile previous revision inline comments.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

chad added a task: T9016: Weird CSS issue with inline comments.

Herald added a subscriber: Korvin. · View Herald TranscriptAug 15 2015, 10:21 PM

epriestley accepted this revision.Aug 17 2015, 12:40 AM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Aug 17 2015, 12:40 AM

Closed by commit rPc9de213750c1: Fix mobile previous revision inline comments (authored by chad, committed by chad). · Explain WhyAug 17 2015, 12:53 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

6 lines

webroot/

rsrc/

css/

application/

differential/

phui-inline-comment.css

6 lines

Diff 33580

View Options

resources/celerity/map.php