Fix Macro active query
ClosedPublic
Actions

Authored by chad on Aug 15 2015, 9:09 PM.

Tags

None

Referenced Files

	F18955959: D13912.diff
	Wed, Nov 12, 9:44 PM

	F18822876: D13912.diff
	Oct 23 2025, 9:02 AM

	F18770542: D13912.id.diff
	Oct 8 2025, 1:14 PM

	F18767323: D13912.diff
	Oct 7 2025, 10:00 PM

	F18467582: D13912.id.diff
	Sep 2 2025, 1:05 PM

	F18462371: D13912.diff
	Sep 1 2025, 10:07 PM

	F18166313: D13912.id33578.diff
	Aug 15 2025, 10:02 AM

	F18008016: D13912.id.diff
	Aug 2 2025, 2:28 PM

View All Files

Subscribers

Korvin

Details

Reviewers

epriestley

Commits

Restricted Diffusion Commit
rPe29255650cf3: Fix Macro active query

Summary

When using the active query in Macro, all Macros are returned. Properly set the status query.

Test Plan

Review active macros, don't see archived macros.

Diff Detail

Repository

rP Phabricator

Branch

macro-query

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 7648
Build 8334: [Placeholder Plan] Wait for 30 Seconds
Build 8333: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 33578.Aug 15 2015, 9:09 PM

chad retitled this revision from to Fix Macro active query.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

Herald added a subscriber: Korvin. · View Herald TranscriptAug 15 2015, 9:09 PM

epriestley accepted this revision.Aug 17 2015, 12:42 AM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Aug 17 2015, 12:42 AM

Closed by commit rPe29255650cf3: Fix Macro active query (authored by chad, committed by chad). · Explain WhyAug 17 2015, 12:50 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

macro/

query/

PhabricatorMacroSearchEngine.php

4 lines

Diff 33578

View Options

src/applications/macro/query/PhabricatorMacroSearchEngine.php

Fix Macro active queryClosedPublicActions