Page MenuHomePhabricator
Differential D13903

Show external build links in applications
ClosedPublic
Actions

Authored by epriestley on Aug 14 2015, 9:56 PM.
Tags
None
Referenced Files
F15198371: D13903.diff
Sun, Feb 23, 2:35 AM
Unknown Object (File)
Tue, Feb 18, 3:47 AM
Unknown Object (File)
Sat, Feb 15, 9:55 AM
Unknown Object (File)
Sun, Feb 9, 9:11 PM
Unknown Object (File)
Sat, Feb 8, 10:04 PM
Unknown Object (File)
Sat, Feb 8, 10:04 PM
Unknown Object (File)
Tue, Feb 4, 2:20 PM
Unknown Object (File)
Sat, Feb 1, 6:44 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T8659: Allow linking to an external build system from Harbormaster
Commits
Restricted Diffusion Commit
rP74bf0d6ec692: Show external build links in applications
Summary

Fixes T8659. This isn't explicitly documented but I'm going to wait for a bit until the "Harbormaster" doc splits into internal/external builds to add docs for it. There's other similar stuff coming soon anyway.

Test Plan

Screen Shot 2015-08-14 at 2.46.49 PM.png (158×579 px, 21 KB)

Screen Shot 2015-08-14 at 2.51.22 PM.png (148×492 px, 19 KB)

Diff Detail

Repository
rP Phabricator
Branch
harboruri2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7638
Build 8314: [Placeholder Plan] Wait for 30 Seconds
Build 8313: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 33560.Aug 14 2015, 9:56 PM
epriestley retitled this revision from to Show external build links in Harbormaster.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T8659: Allow linking to an external build system from Harbormaster.
epriestley retitled this revision from Show external build links in Harbormaster to Show external build links in applications.Aug 14 2015, 9:56 PM
epriestley mentioned this in T8659: Allow linking to an external build system from Harbormaster.Aug 14 2015, 10:04 PM
chad accepted this revision.Aug 14 2015, 10:23 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Aug 14 2015, 10:23 PM
Closed by commit rP74bf0d6ec692: Show external build links in applications (authored by epriestley, committed by epriestley). · Explain WhyAug 15 2015, 2:29 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
harbormaster/
artifact/
9 lines
controller/
48 lines
event/
49 lines
query/
35 lines
41 lines

Diff 33560

View Options

src/applications/harbormaster/artifact/HarbormasterURIArtifact.php

Loading...
View Options

src/applications/harbormaster/controller/HarbormasterBuildViewController.php

Loading...
View Options

src/applications/harbormaster/event/HarbormasterUIEventListener.php

Loading...
View Options

src/applications/harbormaster/query/HarbormasterBuildQuery.php

Loading...
View Options

src/applications/harbormaster/query/HarbormasterBuildTargetQuery.php

Loading...
Phabricator · Built by Phacility