Paths

Table of Contentst

Differential D13899

Fix new Question in Ponder
ClosedPublic
Actions

Authored by chad on Aug 14 2015, 4:33 PM.

Details

Reviewers

epriestley

Commits

Restricted Diffusion Commit
rPe470b6bee2d2: (stable) Promote 2015 Week 33
rP3a6c3cc5ca9e: Fix new Question in Ponder

Summary

I derped here and broke new questions, also remove old Answer constants

Test Plan

Ask a new question, see it save

Diff Detail

Repository

rP Phabricator

Branch

remove-ponder-const

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 7633
Build 8305: [Placeholder Plan] Wait for 30 Seconds
Build 8304: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 33553.Aug 14 2015, 4:33 PM

chad retitled this revision from to Fix new Question in Ponder.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

Herald added a subscriber: Korvin. · View Herald TranscriptAug 14 2015, 4:33 PM

epriestley accepted this revision.Aug 14 2015, 4:35 PM

epriestley edited edge metadata.

epriestley added inline comments.

src/applications/ponder/controller/PonderQuestionEditController.php
71–73	Slightly cleaner is to just only do this part if `!$is_new`.

This revision is now accepted and ready to land.Aug 14 2015, 4:35 PM

cleaner, fix blank details

Closed by commit rP3a6c3cc5ca9e: Fix new Question in Ponder (authored by chad, committed by chad). · Explain WhyAug 14 2015, 4:51 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

ponder/

constants/

PonderQuestionStatus.php

19 lines

controller/

PonderQuestionEditController.php

2 lines

Diff 33553

View Options

src/applications/ponder/constants/PonderQuestionStatus.php