Paths

Table of Contentst

Differential D13894

Add ability to hide answers in Ponder
ClosedPublic
Actions

Authored by chad on Aug 14 2015, 1:50 AM.

Tags

None

Referenced Files

	F15185005: D13894.diff
	Thu, Feb 20, 9:10 PM

	Unknown Object (File)
	Sat, Feb 8, 10:02 PM

	Unknown Object (File)
	Sat, Feb 8, 10:02 PM

	Unknown Object (File)
	Sat, Feb 8, 10:02 PM

	Unknown Object (File)
	Sat, Feb 8, 10:02 PM

	Unknown Object (File)
	Sat, Feb 8, 10:02 PM

	Unknown Object (File)
	Sat, Feb 8, 5:31 AM

	Unknown Object (File)
	Sat, Feb 8, 5:31 AM

Subscribers

Details

Reviewers

Maniphest Tasks

T9173: Allow Answers to be Hidden/Visible

Commits

Restricted Diffusion Commit
rP603c91e08a1f: Add ability to hide answers in Ponder

Summary

Ref T9173, adds basic hide support for answers. Answer authors and Moderators can hide answers, unhide them.

Test Plan

Hide answer, log into other account, see hidden message. Mark as visible, see answer again.

Diff Detail

Repository

Branch

hide-answer

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 7632
Build 8303: [Placeholder Plan] Wait for 30 Seconds
Build 8302: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 33542.Aug 14 2015, 1:50 AM

chad retitled this revision from to Add ability to hide answers in Ponder.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

chad added a task: T9173: Allow Answers to be Hidden/Visible.

Herald added a subscriber: Korvin. · View Herald TranscriptAug 14 2015, 1:50 AM

epriestley accepted this revision.Aug 14 2015, 11:09 AM

epriestley edited edge metadata.

epriestley added inline comments.

src/applications/ponder/constants/PonderQuestionStatus.php
10–11	Maybe put these on a separate `PonderAnswerStatus` class.
src/applications/ponder/storage/PonderAnswerTransaction.php
44	There's no associated remarkup block for this transaction type, right?

This revision is now accepted and ready to land.Aug 14 2015, 11:09 AM

update per comments, clean up feed

Closed by commit rP603c91e08a1f: Add ability to hide answers in Ponder (authored by chad, committed by chad). · Explain WhyAug 14 2015, 4:25 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

sql/

autopatches/

20150812.ponder.answer.1.sql

2 lines

20150812.ponder.answer.2.sql

2 lines

src/

__phutil_library_map__.php

2 lines

applications/

ponder/

constants/

PonderAnswerStatus.php

24 lines

PonderQuestionStatus.php

18 lines

controller/

PonderAnswerEditController.php

14 lines

editor/

PonderAnswerEditor.php

6 lines

storage/

PonderAnswer.php

10 lines

PonderAnswerTransaction.php

28 lines

view/

PonderAnswerView.php

30 lines

Diff 33551

resources/sql/autopatches/20150812.ponder.answer.1.sql

Loading...

resources/sql/autopatches/20150812.ponder.answer.2.sql

Loading...

src/__phutil_library_map__.php

Loading...

src/applications/ponder/constants/PonderAnswerStatus.php

Loading...

src/applications/ponder/constants/PonderQuestionStatus.php

Loading...

src/applications/ponder/controller/PonderAnswerEditController.php

Loading...

src/applications/ponder/editor/PonderAnswerEditor.php

Loading...

src/applications/ponder/storage/PonderAnswer.php

Loading...

src/applications/ponder/storage/PonderAnswerTransaction.php

Loading...

src/applications/ponder/view/PonderAnswerView.php

Loading...