Page MenuHomePhabricator
Differential D13865

Load buildables in DiffViewController
ClosedPublic
Actions

Authored by epriestley on Aug 11 2015, 12:26 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jan 31, 9:28 PM
Unknown Object (File)
Thu, Jan 30, 4:48 AM
Unknown Object (File)
Thu, Jan 30, 4:48 AM
Unknown Object (File)
Fri, Jan 24, 8:02 AM
Unknown Object (File)
Fri, Jan 24, 8:02 AM
Unknown Object (File)
Fri, Jan 24, 8:02 AM
Unknown Object (File)
Fri, Jan 24, 8:01 AM
Unknown Object (File)
Wed, Jan 22, 11:41 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T9128: manually creating/updating a diff is broken
Commits
Restricted Diffusion Commit
rP53ffaaa889ec: Load buildables in DiffViewController
Summary

Fixes T9128. I missed this when converting other controllers to look in Harbormaster for lint/unit data.

Test Plan

Copy/pasted a diff successfully.

Diff Detail

Repository
rP Phabricator
Branch
harborf1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7589
Build 8218: [Placeholder Plan] Wait for 30 Seconds
Build 8217: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 33481.Aug 11 2015, 12:26 PM
epriestley retitled this revision from to Load buildables in DiffViewController.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T9128: manually creating/updating a diff is broken.
chad accepted this revision.Aug 11 2015, 1:36 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Aug 11 2015, 1:36 PM
Closed by commit rP53ffaaa889ec: Load buildables in DiffViewController (authored by epriestley, committed by epriestley). · Explain WhyAug 11 2015, 1:38 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
controller/
11 lines

Diff 33481

View Options

src/applications/differential/controller/DifferentialDiffViewController.php

Loading...
Phabricator · Built by Phacility