Page MenuHomePhabricator
Differential D13844

Don't let autoplans be run manually
ClosedPublic
Actions

Authored by epriestley on Aug 10 2015, 6:33 PM.
Tags
None
Referenced Files
F14039566: D13844.id33431.diff
Mon, Nov 11, 5:57 AM
F14023849: D13844.id33431.diff
Thu, Nov 7, 3:50 AM
F14022555: D13844.id33450.diff
Wed, Nov 6, 6:19 PM
F14022553: D13844.diff
Wed, Nov 6, 6:19 PM
F14001744: D13844.diff
Fri, Oct 25, 11:36 AM
F14001736: D13844.id.diff
Fri, Oct 25, 11:30 AM
F14001735: D13844.id33431.diff
Fri, Oct 25, 11:29 AM
F14001729: D13844.id33450.diff
Fri, Oct 25, 11:27 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T8096: Improve Harbormaster UI/UX (v1)
Commits
Restricted Diffusion Commit
rPa1499ceb8f61: Don't let autoplans be run manually
Summary

Ref T8096. Like stop/start, autoplans are pushed into the system from outside (normally by arc) so it doesn't make any sense to run them manually.

Test Plan
  • Tried to run an autoplan from web UI, got an error.
  • Ran a normal plan from web UI.
  • Tried to run an autoplan from CLI, got an error.
  • Ran a noraml plan from CLI.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 33431.Aug 10 2015, 6:33 PM
epriestley retitled this revision from to Don't let autoplans be run manually.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T8096: Improve Harbormaster UI/UX (v1).
chad accepted this revision.Aug 10 2015, 7:22 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Aug 10 2015, 7:22 PM
Closed by commit rPa1499ceb8f61: Don't let autoplans be run manually (authored by epriestley, committed by epriestley). · Explain WhyAug 10 2015, 9:14 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
harbormaster/
controller/
10 lines
4 lines
management/
5 lines
storage/
configuration/
9 lines

Diff 33450

View Options

src/applications/harbormaster/controller/HarbormasterPlanRunController.php

Loading...
View Options

src/applications/harbormaster/controller/HarbormasterPlanViewController.php

Loading...
View Options

src/applications/harbormaster/management/HarbormasterManagementBuildWorkflow.php

Loading...
View Options

src/applications/harbormaster/storage/configuration/HarbormasterBuildPlan.php

Loading...
Phabricator · Built by Phacility