Differential D13846

Always show build target tabs, even if they have no data
ClosedPublic
Actions

Authored by epriestley on Aug 10 2015, 6:58 PM.

Details

Reviewers

chad

Maniphest Tasks

T8096: Improve Harbormaster UI/UX (v1)

Commits

Restricted Diffusion Commit
rPc2c8b00c5c6b: Always show build target tabs, even if they have no data

Summary

Ref T8096. Hit this on IRC:

epriestley: what's in the Messages tab?
jdoe: what Messages tab??!
epriestley: ughhhh

Test Plan

Clicked "Messages" tab, saw helpful "no messages" message.

Diff Detail

Repository

rP Phabricator

Branch

harbor3

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 7563
Build 8166: [Placeholder Plan] Wait for 30 Seconds
Build 8165: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 33434.Aug 10 2015, 6:58 PM

epriestley retitled this revision from to Always show build target tabs, even if they have no data.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T8096: Improve Harbormaster UI/UX (v1).

haha

This revision is now accepted and ready to land.Aug 10 2015, 7:28 PM

Closed by commit rPc2c8b00c5c6b: Always show build target tabs, even if they have no data (authored by epriestley, committed by epriestley). · Explain WhyAug 10 2015, 9:15 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

harbormaster/

controller/

HarbormasterBuildViewController.php

39 lines

Diff 33434

View Options

src/applications/harbormaster/controller/HarbormasterBuildViewController.php

Always show build target tabs, even if they have no dataClosedPublicActions