Page MenuHomePhabricator
Differential D13830

Fix SQL issue with Ponder migration
ClosedPublic
Actions

Authored by chad on Aug 8 2015, 5:56 PM.
Tags
None
Referenced Files
F14057093: D13830.diff
Sun, Nov 17, 12:22 AM
F14001643: D13830.diff
Fri, Oct 25, 10:35 AM
F14001634: D13830.id.diff
Fri, Oct 25, 10:31 AM
F14001632: D13830.id33397.diff
Fri, Oct 25, 10:30 AM
F14001629: D13830.id33398.diff
Fri, Oct 25, 10:28 AM
F14001628: D13830.id33399.diff
Fri, Oct 25, 10:26 AM
F13983793: D13830.id33397.diff
Sun, Oct 20, 8:40 AM
F13976124: D13830.id33398.diff
Oct 18 2024, 12:56 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Commits
Restricted Diffusion Commit
rP736bda7081c9: Fix SQL issue with Ponder migration
Summary

This fails to apply on my second sandbox with incorrect DOUBLE value. Reran SQL, works as expected.

Test Plan

Rerun new SQL on ponder_question table

Diff Detail

Repository
rP Phabricator
Branch
sql-issue
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7540
Build 8120: [Placeholder Plan] Wait for 30 Seconds
Build 8119: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 33397.Aug 8 2015, 5:56 PM
chad retitled this revision from to Fix SQL issue with Ponder migration.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added a subscriber: Korvin. · View Herald TranscriptAug 8 2015, 5:56 PM
epriestley accepted this revision.Aug 8 2015, 5:56 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Aug 8 2015, 5:56 PM
epriestley added a comment.Aug 8 2015, 5:56 PM

Does the = 0 thing also need = '0' maybe?

chad added a comment.Aug 8 2015, 5:57 PM

It ran fine for me, but maybe it's best to do the quotes anyway? We convert the column first.

chad updated this revision to Diff 33398.Aug 8 2015, 5:58 PM
chad edited edge metadata.
  • Update 0 as well
chad added a comment.Aug 8 2015, 5:59 PM

Do you have somewhere to test this for sanity?

Closed by commit rP736bda7081c9: Fix SQL issue with Ponder migration (authored by chad, committed by chad). · Explain WhyAug 8 2015, 6:07 PM
This revision was automatically updated to reflect the committed changes.
epriestley added a comment.Aug 8 2015, 6:15 PM

You can re-apply the patch as a general sanity check with bin/storage upgrade --apply phabricator: 20150806.ponder.status.2.sql.

MySQL might be a bit loose about typecasting 0, I'm not sure. I'll yell if this does naything bad on this server.

Revision Contents
Changeset List

PathSize
resources/
sql/
autopatches/
2 lines
2 lines

Diff 33398

View Options

resources/sql/autopatches/20150806.ponder.status.2.sql

Loading...
View Options

resources/sql/autopatches/20150806.ponder.status.3.sql

Loading...
Phabricator · Built by Phacility