Ref T6919, Just a basic herald adapter (new questions) for Ponder
Details
Details
- Reviewers
epriestley - Maniphest Tasks
- T6919: Add Herald support to Ponder
- Commits
- Restricted Diffusion Commit
rPdc687dbd92a5: Add basic Herald support to Ponder
Created a Personal Rule, got subscribed to new question, saw transcript.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- ponder-herald
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 7537 Build 8114: [Placeholder Plan] Wait for 30 Seconds Build 8113: arc lint + arc unit
Event Timeline
Comment Actions
Nice! Glad this wasn't too much of a pain.
| src/applications/herald/controller/HeraldTestConsoleController.php | ||
|---|---|---|
| 48–50 | (I need to fix this so it's part of the Adapter at some point..) | |
| src/applications/ponder/herald/HeraldPonderQuestionAdapter.php | ||
| 50–52 | Consider omitting -- the presence of similar methods on other adapters is a bit of a holdover from yesteryear. You can just use getObject(). | |
| 63 | (Then use getObject() here.) | |