Differential D13790

Set a max-height on codeblocks in Conpherence
ClosedPublic
Actions

Authored by chad on Aug 4 2015, 7:44 PM.

Details

Reviewers

epriestley

Commits

Restricted Diffusion Commit
rPf0e7c65d8835: Set a max-height on codeblocks in Conpherence

Summary

Code blocks in Conpherence can be massive and disruptive to a chat-like experience. This caps the height.

Test Plan

Add a ginormous code block to Conpherence, see it hit max-height

Diff Detail

Repository

rP Phabricator

Branch

code-block-conpherence

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 7484
Build 8008: [Placeholder Plan] Wait for 30 Seconds
Build 8007: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 33304.Aug 4 2015, 7:44 PM

chad retitled this revision from to Set a max-height on codeblocks in Conpherence.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

Herald added a subscriber: Korvin. · View Herald TranscriptAug 4 2015, 7:44 PM

epriestley accepted this revision.Aug 4 2015, 7:45 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Aug 4 2015, 7:45 PM

Closed by commit rPf0e7c65d8835: Set a max-height on codeblocks in Conpherence (authored by chad, committed by chad). · Explain WhyAug 4 2015, 7:45 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

4 lines

webroot/

rsrc/

css/

application/

conpherence/

message-pane.css

4 lines

Diff 33304

View Options

resources/celerity/map.php