Page MenuHomePhabricator
Differential D13764

Calendar list objects that are ghost events should link to a ghost event, not the parent
ClosedPublic
Actions

Authored by lpriestley on Jul 31 2015, 5:27 PM.
Tags
None
Referenced Files
F15397147: D13764.diff
Sun, Mar 16, 6:26 PM
F15283398: D13764.diff
Tue, Mar 4, 7:10 AM
Unknown Object (File)
Feb 7 2025, 9:31 PM
Unknown Object (File)
Jan 26 2025, 5:22 PM
Unknown Object (File)
Jan 23 2025, 10:26 AM
Unknown Object (File)
Jan 21 2025, 10:26 AM
Unknown Object (File)
Jan 7 2025, 3:25 AM
Unknown Object (File)
Dec 21 2024, 8:57 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T9034: Calendar list items do not correctly link to ghost events
Commits
Restricted Diffusion Commit
rPf0269d696cfe: Calendar list objects that are ghost events should link to a ghost event, not…
Summary

Fixes T9034, Calendar list objects that are ghost events should link to a ghost event, not the parent.

Test Plan

Open All Events in Calendar, make sure ghost objects open the ghost instance, not the parent instance.

Diff Detail

Repository
rP Phabricator
Branch
calendarobjectlist
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7454
Build 7948: [Placeholder Plan] Wait for 30 Seconds
Build 7947: arc lint + arc unit

Event Timeline

lpriestley updated this revision to Diff 33241.Jul 31 2015, 5:27 PM
lpriestley retitled this revision from to Calendar list objects that are ghost events should link to a ghost event, not the parent.
lpriestley updated this object.
lpriestley edited the test plan for this revision. (Show Details)
lpriestley added a reviewer: epriestley.
lpriestley added a task: T9034: Calendar list items do not correctly link to ghost events.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJul 31 2015, 5:27 PM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
epriestley accepted this revision.Aug 1 2015, 10:39 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Aug 1 2015, 10:39 PM
Closed by commit rPf0269d696cfe: Calendar list objects that are ghost events should link to a ghost event, not… (authored by lpriestley, committed by lpriestley). · Explain WhyAug 3 2015, 2:01 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
calendar/
query/
13 lines

Diff 33241

View Options

src/applications/calendar/query/PhabricatorCalendarEventSearchEngine.php

Loading...
Phabricator · Built by Phacility