Page MenuHomePhabricator
Differential D13749

Add mail/feed to Slowvote
ClosedPublic
Actions

Authored by chad on Jul 28 2015, 8:55 PM.
Tags
None
Referenced Files
F14036352: D13749.id.diff
Sun, Nov 10, 9:51 AM
F14015785: D13749.diff
Mon, Nov 4, 12:42 AM
F14002777: D13749.id33210.diff
Fri, Oct 25, 10:23 PM
F13982435: D13749.id33256.diff
Sat, Oct 19, 11:18 PM
F13980400: D13749.diff
Oct 19 2024, 10:24 AM
F13964669: D13749.id33219.diff
Oct 15 2024, 9:13 PM
F13964353: D13749.id33256.diff
Oct 15 2024, 8:04 PM
F13964352: D13749.id33220.diff
Oct 15 2024, 8:04 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Commits
Restricted Diffusion Commit
rP42c0dd2b8e1b: Add mail/feed to Slowvote
Summary

Adds mailkeys, basic structure for publishing to feed, sending mail.

Test Plan

New Poll, vote, comment, etc.

Diff Detail

Repository
rP Phabricator
Branch
slow-feed
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/slowvote/storage/PhabricatorSlowvoteTransaction.php:138XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 7441
Build 7922: [Placeholder Plan] Wait for 30 Seconds
Build 7921: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 33210.Jul 28 2015, 8:55 PM
chad retitled this revision from to Add mail/feed to Slowvote.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added subscribers: Korvin, epriestley. · View Herald TranscriptJul 28 2015, 8:55 PM
chad planned changes to this revision.Jul 28 2015, 10:38 PM

Doesn't seem to generate feed stories. Will try your daemon trick.

chad updated this revision to Diff 33219.Jul 29 2015, 4:17 AM
  • Fix failing mail
chad updated this revision to Diff 33220.Jul 29 2015, 4:26 AM
  • proper feed stories
epriestley accepted this revision.Aug 1 2015, 10:40 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Aug 1 2015, 10:40 PM
Closed by commit rP42c0dd2b8e1b: Add mail/feed to Slowvote (authored by chad, committed by chad). · Explain WhyAug 1 2015, 10:41 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 33220

View Options

resources/sql/autopatches/20150725.slowvote.mailkey.1.sql

Loading...
View Options

resources/sql/autopatches/20150725.slowvote.mailkey.2.php

Loading...
View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/slowvote/editor/PhabricatorSlowvoteEditor.php

Loading...
View Options

src/applications/slowvote/mail/PhabricatorSlowvoteMailReceiver.php

Loading...
View Options

src/applications/slowvote/mail/PhabricatorSlowvoteReplyHandler.php

Loading...
View Options

src/applications/slowvote/storage/PhabricatorSlowvotePoll.php

Loading...
View Options

src/applications/slowvote/storage/PhabricatorSlowvoteTransaction.php

Loading...
Phabricator · Built by Phacility